Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribute.md file for latest IntelliJ Versions #1417

Merged
merged 2 commits into from
May 3, 2022

Conversation

MariusBrill
Copy link
Member

@MariusBrill MariusBrill commented May 2, 2022

This change is Reviewable

@MariusBrill MariusBrill force-pushed the update_contribute branch from 240eecc to 0c507ec Compare May 2, 2022 13:59
Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MariusBrill)


CONTRIBUTING.md line 9 at r1 (raw file):

We also recommend installing the **Gradle Plugin** and the **[Save Actions Plugin](https://plugins.jetbrains.com/plugin/7642-save-actions)** (Note that you need to make sure your [keymap is up to date](https://youtrack.jetbrains.com/issue/IDEA-277194) for the plugin to work properly).

For IntelliJ 203.* or older, we also advise you to use the **[Lombok Plugin](https://plugins.jetbrains.com/plugin/6317-lombok-plugin)**.

the Lombok Plugin is actually needed for the development of inspectIT Ocelot.

Maybe it's more suitable to say that

You also need the Lombok Plugin. For IntelliJ 203.* and older, you need to manually install it. For IntelliJ XX.* and newer, the Lombok Plugin is bundled in the IDE.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1417 (46268d4) into master (3bff0ca) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1417      +/-   ##
============================================
+ Coverage     81.20%   81.27%   +0.07%     
  Complexity     2109     2109              
============================================
  Files           215      215              
  Lines          6691     6691              
  Branches        785      785              
============================================
+ Hits           5433     5438       +5     
+ Misses          955      950       -5     
  Partials        303      303              
Impacted Files Coverage Δ
...nspectit/ocelot/core/utils/HighPrecisionTimer.java 90.62% <0.00%> (+1.56%) ⬆️
...in/java/rocks/inspectit/ocelot/core/AgentImpl.java 71.43% <0.00%> (+8.16%) ⬆️

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MariusBrill)

@heiko-holz heiko-holz merged commit 777a654 into inspectIT:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants