-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default config for JDBC scopes #1414
Fix default config for JDBC scopes #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions
inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/instrumentation/scopes/db/jdbc.yml
line 27 at r1 (raw file):
's_jdbc_statement_executeBatch': interfaces: - name: 'java.sql.Statement'
This was the actual error
inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/instrumentation/scopes/db/jdbc.yml
line 39 at r1 (raw file):
- name: 'executeBatch' advanced: instrument-only-inherited-methods: true
This was not wrong, but changed for uniformity and avoiding misinterpretations
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
============================================
+ Coverage 81.20% 81.27% +0.07%
- Complexity 2109 2110 +1
============================================
Files 215 215
Lines 6691 6691
Branches 785 785
============================================
+ Hits 5433 5438 +5
+ Misses 955 950 -5
Partials 303 303
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mariusoe)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @aaronweissler from 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)
This change is