Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default config for JDBC scopes #1414

Merged
merged 1 commit into from
May 2, 2022

Conversation

aaronweissler
Copy link
Member

@aaronweissler aaronweissler commented May 2, 2022

This change is Reviewable

@aaronweissler aaronweissler added the bug Something isn't working label May 2, 2022
Copy link
Member Author

@aaronweissler aaronweissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions


inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/instrumentation/scopes/db/jdbc.yml line 27 at r1 (raw file):

      's_jdbc_statement_executeBatch':
        interfaces:
          - name: 'java.sql.Statement'

This was the actual error


inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/instrumentation/scopes/db/jdbc.yml line 39 at r1 (raw file):

          - name: 'executeBatch'
        advanced:
          instrument-only-inherited-methods: true

This was not wrong, but changed for uniformity and avoiding misinterpretations

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1414 (c3492ac) into master (3bff0ca) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1414      +/-   ##
============================================
+ Coverage     81.20%   81.27%   +0.07%     
- Complexity     2109     2110       +1     
============================================
  Files           215      215              
  Lines          6691     6691              
  Branches        785      785              
============================================
+ Hits           5433     5438       +5     
+ Misses          955      950       -5     
  Partials        303      303              
Impacted Files Coverage Δ
...nspectit/ocelot/core/utils/HighPrecisionTimer.java 90.62% <0.00%> (+1.56%) ⬆️
...in/java/rocks/inspectit/ocelot/core/AgentImpl.java 71.43% <0.00%> (+8.16%) ⬆️

Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mariusoe)

Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @aaronweissler from 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)

@mariusoe mariusoe merged commit 431a545 into inspectIT:master May 2, 2022
@aaronweissler aaronweissler deleted the fix/default-config-scopes branch June 7, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants