-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1407 - Insert events into preloaded logs #1411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
============================================
+ Coverage 81.20% 81.23% +0.03%
- Complexity 2109 2110 +1
============================================
Files 215 215
Lines 6691 6706 +15
Branches 785 786 +1
============================================
+ Hits 5433 5447 +14
Misses 955 955
- Partials 303 304 +1
|
Now without beginner's mistakes 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Henning-Schulz and @MariusBrill)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/selfmonitoring/LogPreloader.java
line 65 at r1 (raw file):
if (invalidator != null) { String invalidationString = invalidator.getClass().getSimpleName(); if (invalidationString.endsWith("Event")) {
I am not quite sure why we need this. Maybe we could have a short call about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @MariusBrill)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/selfmonitoring/LogPreloader.java
line 65 at r1 (raw file):
Previously, MariusBrill (Marius Brill) wrote…
I am not quite sure why we need this. Maybe we could have a short call about it?
It is for formatting the log message. I added a comment and changed the code a little to make it better understandable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Henning-Schulz)
Artificially added log events will look like follows.
2022-04-29 10:47:42,709 INFO 33860 --- [inspectIT] [pectit-thread-1] ### LOG-INVALIDATING EVENT ### : Property sources reload! Some previous log messages may now be outdated.
This change is