fix(configdocsgenerator): use Spring to parse Yaml into InspectitConfig

[aaronweissler]

This change is 

[codecov]

Codecov Report

Merging #1362 (b39b1f5) into master (d37a7dc) will decrease coverage by 1.86%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1362      +/-   ##
============================================
- Coverage     83.00%   81.14%   -1.86%     
- Complexity     1736     2070     +334     
============================================
  Files           174      210      +36     
  Lines          5366     6591    +1225     
  Branches        650      784     +134     
============================================
+ Hits           4454     5348     +894     
- Misses          675      945     +270     
- Partials        237      298      +61     

Impacted Files	Coverage Δ
...spectit/ocelot/core/utils/WeakMethodReference.java	0.00% <0.00%> (-77.27%)	⬇️
...strap/correlation/noop/NoopLogTraceCorrelator.java	28.57% <0.00%> (-42.86%)	⬇️
...celot/core/exporter/PrometheusExporterService.java	81.48% <0.00%> (-13.97%)	⬇️
...ial/ScheduledExecutorContextPropagationSensor.java	82.05% <0.00%> (-12.39%)	⬇️
...pectit/ocelot/config/loaders/ConfigFileLoader.java	82.61% <0.00%> (-8.70%)	⬇️
...lot/bootstrap/context/noop/NoopContextManager.java	10.00% <0.00%> (-6.67%)	⬇️
...core/instrumentation/InstrumentationTriggerer.java	85.19% <0.00%> (-5.63%)	⬇️
...rocks/inspectit/ocelot/config/utils/CaseUtils.java	90.48% <0.00%> (-4.98%)	⬇️
...t/ocelot/core/instrumentation/hook/MethodHook.java	95.35% <0.00%> (-4.65%)	⬇️
...del/metrics/definition/ViewDefinitionSettings.java	45.45% <0.00%> (-4.55%)	⬇️
... and 111 more

[heiko-holz]

Reviewed 8 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aaronweissler)

---

components/inspectit-ocelot-configdocsgenerator/src/main/java/inspectit/ocelot/configdocsgenerator/parsing/ConfigParser.java, line 42 at r2 (raw file):

        if (!StringUtils.isEmpty(configYaml)) {

            File tempFile = File.createTempFile("temp-", ".tmp");

The file is then named temp-{...}.tmp?
Maybe sth like inspectit-config-{...} is more appropriate?

---

components/inspectit-ocelot-configdocsgenerator/src/main/java/inspectit/ocelot/configdocsgenerator/parsing/ConfigParser.java, line 49 at r2 (raw file):

            // Read yaml into Properties
            YamlPropertiesFactoryBean factory = new YamlPropertiesFactoryBean();
            factory.setResources(new FileUrlResource(tempFile.getAbsolutePath()));

What is the difference between these lines of code and StringUtils.readYamlFiles(new FileUrlResource(tempFile.getAbsolutePath()));?

---

components/inspectit-ocelot-configdocsgenerator/src/main/java/inspectit/ocelot/configdocsgenerator/parsing/ConfigParser.java, line 51 at r2 (raw file):

            factory.setResources(new FileUrlResource(tempFile.getAbsolutePath()));
            factory.setDocumentMatchers((profile) -> YamlProcessor.MatchStatus.FOUND);
            factory.afterPropertiesSet();

I think this line has no effect if you are not calling factory.setSingleton() before.
And I think this is also redundant if you call factory.getObject() immediately afterwards.

[heiko-holz]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)