-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce issue templates #1312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1312 +/- ##
============================================
- Coverage 83.00% 80.79% -2.21%
- Complexity 1736 2025 +289
============================================
Files 174 204 +30
Lines 5366 6460 +1094
Branches 650 769 +119
============================================
+ Hits 4454 5219 +765
- Misses 675 950 +275
- Partials 237 291 +54
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MariusBrill)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MariusBrill)
.github/ISSUE_TEMPLATE/bug_report.md, line 25 at r1 (raw file):
**Screenshots** If applicable, add screenshots to help explain your problem. If you have a Stacktrace, please copy and paste it here as text.
Do we rather want the users to put the stacktrace into the screenshots sections or add a section stacktrace?
@heiko-holz good question! I think we could either rename the section to something like Additional Material or introduce a second section Stacktraces (or any other speaking name). What would you say is the better option? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would favor "Additional information (screenshots, stacktrace, ."
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MariusBrill)
46e4768
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MariusBrill)
This change is