Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce issue templates #1312

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Introduce issue templates #1312

merged 2 commits into from
Feb 22, 2022

Conversation

MariusBrill
Copy link
Member

@MariusBrill MariusBrill commented Feb 21, 2022

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1312 (46e4768) into master (d37a7dc) will decrease coverage by 2.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1312      +/-   ##
============================================
- Coverage     83.00%   80.79%   -2.21%     
- Complexity     1736     2025     +289     
============================================
  Files           174      204      +30     
  Lines          5366     6460    +1094     
  Branches        650      769     +119     
============================================
+ Hits           4454     5219     +765     
- Misses          675      950     +275     
- Partials        237      291      +54     
Impacted Files Coverage Δ
...spectit/ocelot/core/utils/WeakMethodReference.java 0.00% <0.00%> (-77.27%) ⬇️
...strap/correlation/noop/NoopLogTraceCorrelator.java 28.57% <0.00%> (-42.86%) ⬇️
...ial/ScheduledExecutorContextPropagationSensor.java 82.05% <0.00%> (-12.39%) ⬇️
...pectit/ocelot/config/loaders/ConfigFileLoader.java 82.61% <0.00%> (-8.70%) ⬇️
...lot/bootstrap/context/noop/NoopContextManager.java 10.00% <0.00%> (-6.67%) ⬇️
...core/instrumentation/InstrumentationTriggerer.java 85.19% <0.00%> (-5.63%) ⬇️
...t/ocelot/config/validation/PropertyPathHelper.java 75.56% <0.00%> (-5.06%) ⬇️
...rocks/inspectit/ocelot/config/utils/CaseUtils.java 90.48% <0.00%> (-4.98%) ⬇️
...t/ocelot/core/instrumentation/hook/MethodHook.java 95.35% <0.00%> (-4.65%) ⬇️
...del/metrics/definition/ViewDefinitionSettings.java 45.45% <0.00%> (-4.55%) ⬇️
... and 92 more

aaronweissler
aaronweissler previously approved these changes Feb 21, 2022
Copy link
Member

@aaronweissler aaronweissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MariusBrill)

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MariusBrill)


.github/ISSUE_TEMPLATE/bug_report.md, line 25 at r1 (raw file):

**Screenshots**
If applicable, add screenshots to help explain your problem.
If you have a Stacktrace, please copy and paste it here as text.

Do we rather want the users to put the stacktrace into the screenshots sections or add a section stacktrace?

@heiko-holz heiko-holz self-assigned this Feb 21, 2022
@MariusBrill
Copy link
Member Author

@heiko-holz good question! I think we could either rename the section to something like Additional Material or introduce a second section Stacktraces (or any other speaking name).

What would you say is the better option?

heiko-holz
heiko-holz previously approved these changes Feb 21, 2022
Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would favor "Additional information (screenshots, stacktrace, ."

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MariusBrill)

@MariusBrill MariusBrill dismissed stale reviews from heiko-holz and aaronweissler via 46e4768 February 21, 2022 12:55
Copy link
Member

@aaronweissler aaronweissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MariusBrill)

@MariusBrill MariusBrill merged commit 2aba736 into master Feb 22, 2022
@MariusBrill MariusBrill deleted the Add-issue-template branch March 31, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants