Closes #377 - Prevent recursive method hook execution

[mariusoe]

closes #377

---

This change is 

[codecov]

Codecov Report

Merging #1262 (18d9229) into master (d37a7dc) will decrease coverage by 2.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1262      +/-   ##
============================================
- Coverage     83.00%   80.79%   -2.21%     
- Complexity     1736     2026     +290     
============================================
  Files           174      204      +30     
  Lines          5366     6460    +1094     
  Branches        650      769     +119     
============================================
+ Hits           4454     5219     +765     
- Misses          675      950     +275     
- Partials        237      291      +54     

Impacted Files	Coverage Δ
...spectit/ocelot/core/utils/WeakMethodReference.java	0.00% <0.00%> (-77.27%)	⬇️
...strap/correlation/noop/NoopLogTraceCorrelator.java	28.57% <0.00%> (-42.86%)	⬇️
...ial/ScheduledExecutorContextPropagationSensor.java	82.05% <0.00%> (-12.39%)	⬇️
...pectit/ocelot/config/loaders/ConfigFileLoader.java	82.61% <0.00%> (-8.70%)	⬇️
...lot/bootstrap/context/noop/NoopContextManager.java	10.00% <0.00%> (-6.67%)	⬇️
...core/instrumentation/InstrumentationTriggerer.java	85.19% <0.00%> (-5.63%)	⬇️
...t/ocelot/config/validation/PropertyPathHelper.java	75.56% <0.00%> (-5.06%)	⬇️
...rocks/inspectit/ocelot/config/utils/CaseUtils.java	90.48% <0.00%> (-4.98%)	⬇️
...t/ocelot/core/instrumentation/hook/MethodHook.java	95.35% <0.00%> (-4.65%)	⬇️
...del/metrics/definition/ViewDefinitionSettings.java	45.45% <0.00%> (-4.55%)	⬇️
... and 92 more

[heiko-holz]

Reviewed 3 of 4 files at r1.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @heiko-holz and @mariusoe)

---

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/instrumentation/hook/HookManagerTest.java, line 80 at r1 (raw file):

            // set recursion gate
            HookManager.RECURSION_GATE.set(true);

Is it feasible to also write a "real scenario" test case for which the RECURSION_GATE is not set manually but by the "poorly chosen instrumentation"?
As I am too far away from the implementation, I fail to grasp the example given in #377

[heiko-holz]

Reviewed 1 of 1 files at r2.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @heiko-holz and @mariusoe)

[mariusoe]

Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @heiko-holz)

---

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/instrumentation/hook/HookManagerTest.java, line 80 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

Is it feasible to also write a "real scenario" test case for which the RECURSION_GATE is not set manually but by the "poorly chosen instrumentation"?
As I am too far away from the implementation, I fail to grasp the example given in #377

I've added a system test as well including an instrumentation configuration to cover this case (where an instrumentation calls an instrumented method within its instrumentation). Maybe it is more clear now.

[heiko-holz]

Reviewed 1 of 4 files at r1, 1 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mariusoe)

---

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/instrumentation/hook/HookManagerTest.java, line 80 at r1 (raw file):

Previously, mariusoe (Marius Oehler) wrote…

I've added a system test as well including an instrumentation configuration to cover this case (where an instrumentation calls an instrumented method within its instrumentation). Maybe it is more clear now.

Yes, the tests phenomenally explain the issue :)