Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1003 - Updated default config. #1004

Merged

Conversation

MariusBrill
Copy link
Member

@MariusBrill MariusBrill commented Feb 16, 2021

This change is Reviewable

@MariusBrill MariusBrill linked an issue Feb 16, 2021 that may be closed by this pull request
@MariusBrill MariusBrill force-pushed the Fix_influx_create_database branch from 897a1e5 to 583a820 Compare February 16, 2021 15:30
@MariusBrill MariusBrill changed the title Closes #1003 - Add Influx URL to default config. Closes #1003 - Updated default config. Feb 16, 2021
Copy link
Contributor

@Patrick-Eichhorn Patrick-Eichhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 5 unresolved discussions (waiting on @MariusBrill)


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 123 at r1 (raw file):

        enabled: true

        # The host of the prometheus server.

This is not the host of the prometheus server itself, it is the host of the "prometheus HTTP endpoint"


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 126 at r1 (raw file):

        host: localhost

        # The port of the prometheus server.

""- of the prometheus HTTP endpoint"


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 160 at r1 (raw file):

        # E.g. if the exportInterval is 15s and the buffer-size is 4, the export will keep up to one minute of data in memory.
        buffer-size: 40

Can you extend the influx config with user and password (as comments)


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 166 at r1 (raw file):

        enabled: true

        # location of the jaeger gRPC API.

Upper Case


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 167 at r1 (raw file):

        # location of the jaeger gRPC API.
        # either a valid NameResolver-compliant URI, or an authority string.

Upper Case

Copy link
Member Author

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 5 unresolved discussions (waiting on @Patrick-Eichhorn)


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 123 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

This is not the host of the prometheus server itself, it is the host of the "prometheus HTTP endpoint"

Done.


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 126 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

""- of the prometheus HTTP endpoint"

Done.


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 160 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

Can you extend the influx config with user and password (as comments)

Done.


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 166 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

Upper Case

Done.


components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 167 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

Upper Case

Done.

Copy link
Contributor

@Patrick-Eichhorn Patrick-Eichhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Patrick-Eichhorn)

Copy link
Contributor

@Patrick-Eichhorn Patrick-Eichhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Patrick-Eichhorn Patrick-Eichhorn merged commit b6a47ed into inspectIT:master Feb 17, 2021
@MariusBrill MariusBrill deleted the Fix_influx_create_database branch May 25, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default config.
2 participants