-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1003 - Updated default config. #1004
Closes #1003 - Updated default config. #1004
Conversation
…notation for jaeger.url
897a1e5
to
583a820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 5 unresolved discussions (waiting on @MariusBrill)
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 123 at r1 (raw file):
enabled: true # The host of the prometheus server.
This is not the host of the prometheus server itself, it is the host of the "prometheus HTTP endpoint"
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 126 at r1 (raw file):
host: localhost # The port of the prometheus server.
""- of the prometheus HTTP endpoint"
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 160 at r1 (raw file):
# E.g. if the exportInterval is 15s and the buffer-size is 4, the export will keep up to one minute of data in memory. buffer-size: 40
Can you extend the influx config with user and password (as comments)
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 166 at r1 (raw file):
enabled: true # location of the jaeger gRPC API.
Upper Case
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 167 at r1 (raw file):
# location of the jaeger gRPC API. # either a valid NameResolver-compliant URI, or an authority string.
Upper Case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 5 unresolved discussions (waiting on @Patrick-Eichhorn)
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 123 at r1 (raw file):
Previously, Patrick-Eichhorn wrote…
This is not the host of the prometheus server itself, it is the host of the "prometheus HTTP endpoint"
Done.
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 126 at r1 (raw file):
Previously, Patrick-Eichhorn wrote…
""- of the prometheus HTTP endpoint"
Done.
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 160 at r1 (raw file):
Previously, Patrick-Eichhorn wrote…
Can you extend the influx config with user and password (as comments)
Done.
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 166 at r1 (raw file):
Previously, Patrick-Eichhorn wrote…
Upper Case
Done.
components/inspectit-ocelot-eum-server/src/main/resources/application.yml, line 167 at r1 (raw file):
Previously, Patrick-Eichhorn wrote…
Upper Case
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Patrick-Eichhorn)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is