Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Server's RevisionAccess returns invalid results when listing nested files #816

Closed
mariusoe opened this issue Jul 8, 2020 · 0 comments · Fixed by #817
Closed
Assignees
Labels
area/config-server bug Something isn't working

Comments

@mariusoe
Copy link
Member

mariusoe commented Jul 8, 2020

The current implementation of the rocks.inspectit.ocelot.file.accessor.git.RevisionAccess#collectFiles contains a bug which leads to invalid results.
The mentioned method recursivly list files in a specified directory but does not handle the case when the tree walker leaves a directory, leading to the problem that all files will end up in one single directory in the resulting data structure.

Example:
the following structure

/file.yml
/first/file_a.yml
/second/file_b.yml

would be represented as

/file.yml
/first/file_a.yml
/first/second/file_b.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config-server bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant