Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading React dependency of the configuration UI to the latest version #813

Closed
AlexanderWert opened this issue Jul 7, 2020 · 0 comments · Fixed by #814
Closed

Upgrading React dependency of the configuration UI to the latest version #813

AlexanderWert opened this issue Jul 7, 2020 · 0 comments · Fixed by #814
Assignees
@AlexanderWert
Labels
area/config-ui

Comments

@AlexanderWert
Copy link
Contributor

AlexanderWert commented Jul 7, 2020 •
edited by mariusoe
Loading

The React dependency of the configuration UI should be upgrade to the latest version.

In the latest version, some lifecycle method are deprecated. Classes using these function should be refactored, thus, deprecation warnings are resolved.

  • componentWillReceiveProps is deprecated since React 16.9.0
  • componentWillMount is deprecated since React 16.9.0
@AlexanderWert AlexanderWert self-assigned this Jul 7, 2020
AlexanderWert pushed a commit to AlexanderWert/inspectit-oce that referenced this issue Jul 7, 2020
Closes inspectIT#813 - fixed deprecated warning
bb37433
AlexanderWert pushed a commit to AlexanderWert/inspectit-oce that referenced this issue Jul 7, 2020
Closes inspectIT#813 - fixed deprecated warning
97fccd1
@mariusoe mariusoe changed the title Fix deprecated function calls Upgrading React dependency of the configuration UI to the latest version Jul 8, 2020
@mariusoe mariusoe linked a pull request Jul 8, 2020 that will close this issue
Closes #813 - Upgrading React dependency of the configuration UI to the latest version #814
Merged
AlexanderWert pushed a commit to AlexanderWert/inspectit-oce that referenced this issue Jul 8, 2020
Closes inspectIT#813 - resolved review comments
723ad1b
mariusoe added a commit that referenced this issue Jul 9, 2020
@AlexanderWert @mariusoe
Closes #813 - Upgrading React dependency of the configuration UI to t…
515b602 
…he latest version (#814)

Co-authored-by: Marius Oehler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderWert AlexanderWert

Labels
area/config-ui
Projects
None yet
Milestone
No milestone
2 participants
@AlexanderWert @mariusoe