Closes #1319 - Add filter for inspectit.env path in autocompletion (#…

…1339) * Add filter for inspectit.env path in autocompletion * Update tests
inspectIT · Mar 3, 2022 · 7cb1ee6 · 7cb1ee6
1 parent b0e71e1
commit 7cb1ee6
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/...c/main/java/rocks/inspectit/ocelot/autocomplete/autocompleterimpl/ModelAutoCompleter.java b/...c/main/java/rocks/inspectit/ocelot/autocomplete/autocompleterimpl/ModelAutoCompleter.java
@@ -1,7 +1,5 @@
 package rocks.inspectit.ocelot.autocomplete.autocompleterimpl;
 
-import static rocks.inspectit.ocelot.autocomplete.autocompleterimpl.Constants.INSPECTIT;
-
 import com.google.common.annotations.VisibleForTesting;
 import org.springframework.beans.BeanUtils;
 import org.springframework.stereotype.Component;
@@ -18,6 +16,8 @@
 import java.util.List;
 import java.util.stream.Collectors;
 
+import static rocks.inspectit.ocelot.autocomplete.autocompleterimpl.Constants.INSPECTIT;
+
 @Component
 public class ModelAutoCompleter implements AutoCompleter {
 
@@ -41,7 +41,9 @@ public List<String> getSuggestions(List<String> path) {
     private List<String> collectProperties(List<String> propertyPath) {
         Type endType = PropertyPathHelper.getPathEndType(propertyPath, InspectitConfig.class);
         if (CollectionUtils.isEmpty(propertyPath) || ((propertyPath.size() == 1) && propertyPath.get(0).equals(""))) {
-            return getProperties(InspectitConfig.class);
+            return getProperties(InspectitConfig.class).stream()
+                    //Filter out the path "inspectit.env" which may only be managed by the agent.
+                    .filter(property -> !property.equals("env")).collect(Collectors.toList());
         }
         if (endType instanceof Class<?> && ((Class<?>) endType).isEnum()) {
             return Arrays.stream(((Class<?>) endType).getEnumConstants())

diff --git a/...st/java/rocks/inspectit/ocelot/autocomplete/autocompleterimpl/ModelAutoCompleterTest.java b/...st/java/rocks/inspectit/ocelot/autocomplete/autocompleterimpl/ModelAutoCompleterTest.java
@@ -6,6 +6,7 @@
 import rocks.inspectit.ocelot.config.model.InspectitConfig;
 
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 
 import static org.assertj.core.api.Assertions.assertThat;
@@ -46,7 +47,7 @@ void pastList() {
 
             List<String> result = completer.getSuggestions(input);
 
-            assertThat(result).containsExactlyInAnyOrder("config", "env", "exporters", "instrumentation", "logging", "metrics", "plugins", "privacy", "publish-open-census-to-bootstrap", "self-monitoring", "service-name", "tags", "thread-pool-size", "tracing", "agent-commands");
+            assertThat(result).containsExactlyInAnyOrder("config", "exporters", "instrumentation", "logging", "metrics", "plugins", "privacy", "publish-open-census-to-bootstrap", "self-monitoring", "service-name", "tags", "thread-pool-size", "tracing", "agent-commands");
         }
 
         @Test
@@ -124,6 +125,24 @@ void startsNotWithInspectit() {
 
             assertThat(result).isEmpty();
         }
+
+        @Test
+        void filtersInspectitEnvPath() {
+            List<String> input = Collections.singletonList("inspectit");
+
+            List<String> result = completer.getSuggestions(input);
+
+            assertThat(result).doesNotContain("env");
+        }
+
+        @Test
+        void ignoresPastInspectitEnvPath() {
+            List<String> input = Collections.singletonList("inspectit.env");
+
+            List<String> result = completer.getSuggestions(input);
+
+            assertThat(result).isEmpty();
+        }
     }
 
     @Nested