feature: add shutdown notifier #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levinkerschberger
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
The implementation is pretty good! Approved.
However,
I did a little bit of research, googeling and gpt´ing and jumped into a "how to make the shutdown-hook-manager-hole".
Apache Hadoop has a very similar one to our´s.
So...I created a gist with my version of a ShutdownHookManager. Don´t blame me for doing stuff like that in my freetime, but I think it came out pretty beautiful.
Have a look and tell me what you think about it:
https://gist.github.com/levinkerschberger/962cb4277ec5b85e3a4a8ad7d52fb7e5
...-agent/src/main/java/rocks/inspectit/gepard/agent/internal/shutdown/ShutdownHookManager.java
Outdated
Show resolved
Hide resolved
...-agent/src/main/java/rocks/inspectit/gepard/agent/internal/shutdown/ShutdownHookManager.java
Outdated
Show resolved
Hide resolved
inspectit-gepard-agent/src/main/java/rocks/inspectit/gepard/agent/InspectitAgentExtension.java
Show resolved
Hide resolved
...-agent/src/main/java/rocks/inspectit/gepard/agent/internal/shutdown/ShutdownHookManager.java
Outdated
Show resolved
Hide resolved
...-agent/src/main/java/rocks/inspectit/gepard/agent/internal/shutdown/ShutdownHookManager.java
Outdated
Show resolved
Hide resolved
...agent/src/test/java/rocks/inspectit/gepard/agent/configuration/ConfigurationManagerTest.java
Outdated
Show resolved
Hide resolved
...nt/src/test/java/rocks/inspectit/gepard/agent/internal/shutdown/ShutdownHookManagerTest.java
Show resolved
Hide resolved
...nt/src/test/java/rocks/inspectit/gepard/agent/notification/http/NotificationFactoryTest.java
Show resolved
Hide resolved
|
I will surely take some inspiration from your and Hadoops's code |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.