feature: prevent span duplicates #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levinkerschberger
requested changes
Oct 22, 2024
...nt/src/main/java/rocks/inspectit/gepard/agent/instrumentation/hook/action/util/SpanUtil.java
Show resolved
Hide resolved
...d-agent/src/main/java/rocks/inspectit/gepard/agent/transformation/TransformationManager.java
Outdated
Show resolved
Hide resolved
levinkerschberger
requested changes
Oct 22, 2024
...ent/src/test/java/rocks/inspectit/gepard/agent/integrationtest/spring/trace/TracingTest.java
Show resolved
Hide resolved
...ent/src/test/java/rocks/inspectit/gepard/agent/integrationtest/spring/trace/TracingTest.java
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no span duplicates, if inspectIT is configured to create spans for a method, which is already recorded by OpenTelemetry. For example via zero-code-instrumentation or @WithSpan-annotation.
We can only prevent a span duplicate, if the OTel span was created before ours (which is the case for the examples mentioned above).