Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] use globalThis if available #53

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[Refactor] use globalThis if available #53

merged 1 commit into from
Aug 31, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Aug 31, 2021

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #53 (9185d8a) into main (67fd6b2) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   89.74%   90.00%   +0.25%     
==========================================
  Files           1        1              
  Lines          39       40       +1     
  Branches        9       10       +1     
==========================================
+ Hits           35       36       +1     
  Misses          4        4              
Impacted Files Coverage Δ
index.js 90.00% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67fd6b2...9185d8a. Read the comment docs.

@JounQin
Copy link
Contributor Author

JounQin commented Aug 31, 2021

@ljharb Any time to review? It seems the last one to make it work on my machine.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd still strongly suggest using a non-broken bundler, or configuring your bundler to work properly.

@ljharb ljharb merged commit 9185d8a into inspect-js:main Aug 31, 2021
@JounQin JounQin deleted the refactor/globalThis branch August 31, 2021 05:57
@JounQin
Copy link
Contributor Author

JounQin commented Aug 31, 2021

i'd still strongly suggest using a non-broken bundler, or configuring your bundler to work properly.

@ljharb Thanks, as you can see, I was trying to polyfill global in vite at vitejs/vite#4796 but failed, a new plugin vite-plugin-provide will be created for this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants