Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compatible for browser environment #12

Closed
wants to merge 1 commit into from
Closed

compatible for browser environment #12

wants to merge 1 commit into from

Conversation

HansHuang
Copy link

Background
has-symbols is widely referenced in both node and browser environment, weeks ago got below error in browser's console:

ReferenceError: global is not defined

So the PR is to add type defense for browser environment.

ljharb
ljharb requested changes Dec 28, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed; all working bundlers transform global to window.

@ljharb
Copy link
Member

ljharb commented Dec 28, 2019

Duplicate of #4. Duplicate of #6. Duplicate of #11.

@ljharb ljharb closed this Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HansHuang @ljharb