-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to react-router 3.0.0 and fix issue with passing unknown props #8
base: master
Are you sure you want to change the base?
Conversation
@insin Found that react-router-active-component doesn't work with react-router 3.0.0. Please take a look at this PR. Maybe you find it useful |
Current coverage is 88.23% (diff: 90.90%)@@ master #8 diff @@
==========================================
Files 1 1
Lines 25 34 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 21 30 +9
Misses 4 4
Partials 0 0
|
Please pull into master so that we can use with the latest react! |
If you don't want to wait till this gets merged and you use react router v3 in your project: you don't need this plugin to achieve the active state on a parent node - it's simple enough without lib. Just use a component as per: Link |
+1 |
2 similar comments
+1 |
+1 |
+1 can this please be merged |
No description provided.