Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to react-router 3.0.0 and fix issue with passing unknown props #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

killmenot
Copy link

No description provided.

@killmenot
Copy link
Author

@insin Found that react-router-active-component doesn't work with react-router 3.0.0. Please take a look at this PR. Maybe you find it useful

@coveralls
Copy link

Coverage Status

Coverage increased (+4.2%) to 88.235% when pulling a378f00 on killmenot:react-router-3.0.0 into f0f87c1 on insin:master.

@codecov-io
Copy link

Current coverage is 88.23% (diff: 90.90%)

Merging #8 into master will increase coverage by 4.23%

@@             master         #8   diff @@
==========================================
  Files             1          1          
  Lines            25         34     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             21         30     +9   
  Misses            4          4          
  Partials          0          0          

Powered by Codecov. Last update f0f87c1...a378f00

@4ware
Copy link

4ware commented Nov 7, 2016

Please pull into master so that we can use with the latest react!

@kkarkos
Copy link

kkarkos commented Feb 16, 2017

If you don't want to wait till this gets merged and you use react router v3 in your project: you don't need this plugin to achieve the active state on a parent node - it's simple enough without lib. Just use a component as per: Link

@dbkaplun
Copy link

+1

2 similar comments
@jes5e
Copy link

jes5e commented Apr 7, 2017

+1

@mucahit
Copy link

mucahit commented May 24, 2017

+1

@coxjc
Copy link

coxjc commented Aug 25, 2017

+1 can this please be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants