Updating React and ReactDOM dependencies to v15 #44
Conversation
| @@ -31,13 +31,13 @@ | |||
| "inputmask-core": "^2.1.1" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "0.14.x" | |||
| "react": "15.x.x" | |||
There was a problem hiding this comment.
i would recommend "0.14.x || 15.0.x"
There was a problem hiding this comment.
agreed. Either that, or *, or remove peerDeps entirely.
There was a problem hiding this comment.
Thanks, @szyablitsky and @iamdustan! Good points. I like the idea of 0.14.x || 15.0.x; it doesn't allow major or minor updates, which could introduce breaking changes, and communicates at a glance which versions are supported. Updated!
There was a problem hiding this comment.
oh actually I would prefer 15.x.x
There was a problem hiding this comment.
in the || column. Minor versions are unlikely to introduce breaking changes and we by default support all future versions. The difference, IMO, will be when we drop support for older versions if newer versions make it difficult.
|
last nit: could you squash this to a single commit? Then I’ll merge and publish. |
…atch updates in peerDependencies
thathenderson
force-pushed
the
update-to-react-15
branch
from
89b7b5b to
898a14a
Compare
|
@iamdustan Done! |
I used 15.x.x to try to future-proof the React dependencies; should be good for a little while. (15.0.1 was released while I was doing this, which fixed this cursor issue: facebook/react#6445)
No warnings in the console. I tried
npm test, but there aren't any tests to run.