Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit linter exceptions #1119

Merged
merged 2 commits into from
Mar 1, 2024
Merged

audit linter exceptions #1119

merged 2 commits into from
Mar 1, 2024

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Mar 1, 2024

Removed superfluous # nolint statements.
Added linter specification to remaining exceptions.

@chlebowa chlebowa added the core label Mar 1, 2024
@chlebowa chlebowa enabled auto-merge (squash) March 1, 2024 11:20
Copy link
Contributor

github-actions bot commented Mar 1, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  30      21  30.00%   21-33, 36-43
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      31  63.95%   107-114, 160-161, 163, 175-196, 226-227, 229
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      36  66.36%   37-43, 50-58, 67-72, 195, 200-213
R/module_nested_tabs.R              154      58  62.34%   39-112, 128, 180, 202, 228
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R         76      33  56.58%   33-68, 100, 116
R/module_teal_with_splash.R         114       4  96.49%   110, 131, 197-198
R/module_teal.R                     106      29  72.64%   57, 68, 77, 150-151, 157, 176-207
R/modules.R                         153      27  82.35%   127-130, 147-151, 206-210, 292-293, 345, 357-365, 419-422
R/reporter_previewer_module.R        18       2  88.89%   30, 34
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/utils.R                           196      28  85.71%   117-144, 292
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1690     533  68.46%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 177870a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Unit Tests Summary

  1 files   19 suites   10s ⏱️
208 tests 208 ✅ 0 💤 0 ❌
419 runs  419 ✅ 0 💤 0 ❌

Results for commit 177870a.

♻️ This comment has been updated with latest results.

@chlebowa chlebowa requested a review from m7pr March 1, 2024 13:22
@chlebowa chlebowa merged commit 05cddce into main Mar 1, 2024
23 checks passed
@chlebowa chlebowa deleted the specific_linter_exceptions@main branch March 1, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants