Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/installation: switch link syntax from markdown to html #939

Merged
merged 5 commits into from
Dec 28, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Dec 27, 2022

Description of proposed changes

  • docs/installation:

    • switch link syntax from markdown to html, because the markdown link syntax within html tag, e.g. the , does not work on readthedocs.
    • remove the unnecessary link to section 3, as suggested by @falkamelung.
  • .github/dependabot.yml: ignore patch updates for all dependencies to reduce the PR frequency

  • utils.readfile.get_hdf5_dataset_attrs(): return None, instead of raising an error, if the input file is not hdf5, for more compatibility

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ docs/installation:
   - switch link syntax from markdown to html, because the the markdown link syntax within html tag, e.g. the <detail>, does not work on readthedocs.
   - remove the unnecessary link to section 3.

+ .github/dependabot.yml: ignore patch updates for all dependencies to reduce the PR frequency

+ utils.readfile.get_hdf5_dataset_attrs(): return None, instead of raise error, if input file is not hdf5, for more compatiability
@yunjunz yunjunz merged commit c7400f9 into insarlab:main Dec 28, 2022
@yunjunz yunjunz deleted the doc branch December 28, 2022 02:38
yunjunz added a commit that referenced this pull request Dec 28, 2022
+ `objects.resample.prepare_geometry_definition_radar()`: update the initially guessed `num_box` value, based on the later-on-calculated actually-used `dest_box_list`. These two could occasionally be different when the input file is large.

+ use `use scipy.interpolate.RegularGridInterpolator` without `as RGI` in the following scripts, as suggested by codacy.
   - objects.resample.py
   - tropo_gacos.py
   - utils.utils0.py

+ `.github./dependabot.yml`: fix typo introduced in #939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant