use sh instead of bash in load_data_aoi.sh

[avalentino]

Use the correct shell in the shebang string

The mintpy/sh/load_data_aoi.sh script is supposed to work with a standard unix sh shell but it actually contain some statements using a bash specific syntax.

$ sh -n mintpy/sh/load_data_aoi.sh 
mintpy/sh/load_data_aoi.sh: 49: Syntax error: redirection unexpected

Reminders

• Fix #xxxx
• Pass Codacy code review (green)
• Pass Circle CI test (green)
• Make sure that your code follows our style. Use the other functions/files as a basis.
• If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
• If adding new functionality, add a detailed description to the documentation and/or an example.

[welcome]

💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖
Keep in mind that all new features should be documented. It helps to write the comments next to the code or below your functions describing all arguments, and return types before writing the code. This will help you think about your code design and usually results in better code.

[avalentino]

Just for my curiosity, what is the purpose of having the mintpy/sh/*.sh scripts inside the mintpy Python package folder?
It seems to me that none of them is used in the Python code, so probably it could be a good idea to move them to another place.
Do I miss something?

[yunjunz]

You are right. Only sh/plot_smallbaselineApp.sh was used before in the code, but not anymore. I like the idea of moving them to another place. Do you have any suggestions for it?

[yunjunz]

LGTM.

[avalentino]

You are right. Only 'sh/plot_smallbaselineApp.sh` was used before in the code, but not anymore. I like the idea of moving them to another place. Do you have any suggestions for it?

Probably it could be a scripts folder in the project root.
If you need to install those scripts, you could use the scripts argument of setuptools.setup.
In that case, anyway, I recommend to prefix your scripts with e.g. mintpy- in order to make it easy to recognize mintpy related stuff in the global /usr/bin/ folder (on unix at least).

If you want I can prepare a patch for it, but it will be not before a week.
I will be traveling the next week.

[yunjunz]

Having them in a scripts folder sounds good to me. Since they are not used currently, we don't need to install them. One could easily find them in the repo if they want to use them independently. I will wait for your PR then.