Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resample: bugfix for auto_lat_lon_step_size() via merged src/lut_meta dict #737

Merged
merged 4 commits into from
Feb 6, 2022

Conversation

bbuzz31
Copy link
Contributor

@bbuzz31 bbuzz31 commented Feb 4, 2022

Description of proposed changes

This fixes #736 by passing all possible metadata to the geocoding functions.

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@yunjunz yunjunz changed the title Bb geocode resample resample: bugfix for the new auto_lat_lon_step_size() via merged src/lut_meta dict Feb 4, 2022
@yunjunz yunjunz changed the title resample: bugfix for the new auto_lat_lon_step_size() via merged src/lut_meta dict resample: bugfix for auto_lat_lon_step_size() via merged src/lut_meta dict Feb 4, 2022
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixing @bbuzz31!

@yunjunz yunjunz merged commit 569dd96 into insarlab:main Feb 6, 2022
@bbuzz31 bbuzz31 deleted the bb-geocode_resample branch July 6, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected changes while geocoding
2 participants