Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: add get_version_info_v2() #1231

Merged
merged 1 commit into from
Jul 21, 2024
Merged

version: add get_version_info_v2() #1231

merged 1 commit into from
Jul 21, 2024

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Jul 21, 2024

Description of proposed changes

  • version: add get_version_info_v2() using importlib.metadata module, but it's not working yet, as described below, thus, not used yet.

    • 1st, the returned version is not correct: 1.5.1.post55, which should be 1.5.3.post2
    • 2nd, the returned date is not correct: None, which should be 2023-12-05
  • version: remove the unused website and description vars

  • docs/demo*: update relevant literature for San Francisco Bay dataset using GMTSAR to Xu et al. (2021, JGR)

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Pass local test
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ add get_version_info_v2() using importlib.metadata module, but it's not working yet, as described below, thus, not used yet.

   - 1st, the returned version is not correct: 1.5.1.post55, which should be 1.5.3.post2
   - 2nd, the returned date is not correct: None, which should be 2023-12-05

+ remove the unused `website` and `description` vars

+ docs/demo*: update relevant literature for San Francisco Bay dataset using GMTSAR to Xu et al. (2021, JGR)
@yunjunz yunjunz changed the title version: add get_version_info_v2() version: add get_version_info_v2() Jul 21, 2024
@yunjunz yunjunz merged commit 3d926c7 into insarlab:main Jul 21, 2024
6 of 7 checks passed
@yunjunz yunjunz deleted the version branch July 21, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant