Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils0.incidence_angle: read from metadata directly if available for dimension==0 #1152

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

taliboliver
Copy link
Contributor

@taliboliver taliboliver commented Mar 5, 2024

Adding option to read center incidence angle from attribute file if available and use it as preferred option.

Proposing these changes after encountering a range_n value smaller that the acquisition height for UAVSAR dataset swatch_00540.

This error was also encountered by @alhandwerger

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

Adding option to read center incidence angle from metadata if available and use it as preferred option.
@yunjunz yunjunz self-requested a review March 5, 2024 15:04
@yunjunz yunjunz changed the title Read incidence angle from attribute file in utils0.py utils0.incidence_angle: read from metadata directly if available for dimension==0 Mar 5, 2024
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @taliboliver for the fix, LGTM.

@yunjunz yunjunz merged commit 0363d89 into insarlab:main Mar 5, 2024
8 checks passed
@taliboliver taliboliver deleted the center_inc_angle branch March 5, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants