Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: add shapely #1069

Merged
merged 1 commit into from
Aug 10, 2023
Merged

dep: add shapely #1069

merged 1 commit into from
Aug 10, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Aug 10, 2023

Description of proposed changes

  • dependency: add shapely to requirements.txt and setup.py file, as it's used in objects.euler_pole.py to plot plate motion since euler_pole: add PMM plotting functions #935. Note that 1) shapely is already a dependency for cartopy, so this won't really affect the mintpy installation; 2) shapely has been added explicitly to the dependency on conda-forge for mintpy (mintpy v1.5.2 conda-forge/mintpy-feedstock#10)

  • docs/installation/argcomplete: replace conda with brew for bash installation, so that the bash is independent of the conda directory, which can be removed more easily/frequently than /usr/local directory from brew.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.

+ dependency: add shapely to requirements.txt and setup.py file, as it's used in `objects.euler_pole.py` to plot plate motion since insarlab#935. Note that shapely is the dependency for cartopy already, so this won't really affect the mintpy installation.

+ docs/installation/argcomplete: replace conda with brew for bash installation, so that the bash is independent from the conda directory, which can removed more easily/frequently than /usr/local directory from brew.
@yunjunz yunjunz merged commit 62b369d into insarlab:main Aug 10, 2023
@yunjunz yunjunz deleted the doc branch August 10, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant