Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prep_nisar to load NISAR GUNW products #1035

Merged
merged 17 commits into from
Sep 8, 2023

Conversation

mirzaees
Copy link
Collaborator

Description of proposed changes

Add prep_nisar.py script to read GUNW products. The inputs are a list of nisar*.h5 data cubes and the DEM.

Future to do list:

  • The water mask in the test products is all zero. To avoid masking the data, it was manually set to one. We need to remove manual part after correctly adding water mask to input data.
  • Tropospheric correction of Mintpy using pyaps does not perform well because of UTM coordinate system. We might read the correction layers from input data instead in the future. But for now, the height_correlation option works.
  • The x/y coordinates of data cube in radarGrid require to add a margin to cover the x/y coordinates of GUNW. For now the common bounding box to read all data is the area covered by both radarGrid and GUNW grid, meaning we cut the outer edges if needed.
  • The auto path for the input products is set to "../interferograms/*.h5". It might change based on where the GUNW products are located after processing with isce3

Copy link
Contributor

@scottstanie scottstanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what @yunjunz will think about the radar grid/geo-grid problem... the incidence/bperp being on a different grid is why Sara had to add all the extra checks/interpolation/creation of a larger bounding box that each product is inside.

  • It's probably necessary that the geometry.h5 file is on the same geocoded grid as the ifgramStack.h5, right? Maybe we could just warp the geometry ones to be on the same as the GUNW grid using gdalwarp?

src/mintpy/prep_nisar.py Show resolved Hide resolved
src/mintpy/prep_nisar.py Outdated Show resolved Hide resolved
@yunjunz yunjunz changed the title Prep script for nisar add prep_nisar to read NISAR GUNW products Jul 5, 2023
@yunjunz yunjunz changed the title add prep_nisar to read NISAR GUNW products add prep_nisar to load NISAR GUNW products Jul 5, 2023
yunjunz added 2 commits July 5, 2023 16:06
+ add an entry point for prep_nisar in setup.py

+ add subparser for prep_nisar in __main__.py
src/mintpy/cli/prep_nisar.py Outdated Show resolved Hide resolved
src/mintpy/cli/prep_nisar.py Outdated Show resolved Hide resolved
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mirzaees for the exciting PR! Sorry for my very late review, I got distracted by the EarthScope course and proposal writings.

I don't really have a good grasp on the radar/geo-grid of the geometry files that @scottstanie was mentioning. Is there an open interferogram stack in the NISAR format, or a detailed description of the InSAR file format, that we could test? Otherwise, the PR is fine with me to merge since it does not break any other codes.

src/mintpy/prep_nisar.py Show resolved Hide resolved
@mirzaees
Copy link
Collaborator Author

mirzaees commented Sep 7, 2023

Thank you @yunjunz for reviewing
I do not have an open interferogram stack but I have tested this, and confirm it is working. So let's merge it if it is fine with you.

@yunjunz yunjunz merged commit ce93e2e into insarlab:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants