Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

Version 0.3 #72

Merged
merged 38 commits into from
Jun 13, 2019
Merged

Version 0.3 #72

merged 38 commits into from
Jun 13, 2019

Conversation

michielbdejong
Copy link
Contributor

@michielbdejong michielbdejong commented May 7, 2019 •
edited
Loading

@michielbdejong michielbdejong changed the base branch from master to rdf-component May 7, 2019 17:55
@michielbdejong michielbdejong changed the base branch from rdf-component to master May 9, 2019 10:31
jaxoncreed
jaxoncreed previously approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@jaxoncreed jaxoncreed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait work in progress

@jaxoncreed jaxoncreed dismissed their stale review May 13, 2019 12:50

It's a work in progress

@michielbdejong michielbdejong changed the title [WiP] Version 0.3 Version 0.3 May 24, 2019
@michielbdejong
Copy link
Contributor Author

@jaxoncreed please review

jaxoncreed
jaxoncreed reviewed May 29, 2019
View reviewed changes
Copy link
Contributor

@jaxoncreed jaxoncreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. You've done an amazing amount of work. I only hope to eventually be this good ;)

README.md Show resolved Hide resolved
src/__mocks__/node-fetch.ts Show resolved Hide resolved
src/lib/auth/appIsTrustedForMode.ts Show resolved Hide resolved
src/lib/auth/appIsTrustedForMode.ts Show resolved Hide resolved
src/lib/auth/appIsTrustedForMode.ts Outdated Show resolved Hide resolved
src/lib/auth/appIsTrustedForMode.ts Show resolved Hide resolved
src/lib/auth/determineAllowedAgentsForModes.ts Show resolved Hide resolved
src/lib/auth/determineAllowedAgentsForModes.ts Outdated Show resolved Hide resolved
src/lib/core/checkAccess.ts Outdated Show resolved Hide resolved
src/lib/storage/BlobTree.ts Show resolved Hide resolved
@michielbdejong
Copy link
Contributor Author

Wow. You've done an amazing amount of work. I only hope to eventually be this good ;)

Thanks for the compliment! Surely you're exaggerating :)

And thanks for the review, all good points, will process the changes tomorrow.

@michielbdejong michielbdejong mentioned this pull request Jun 12, 2019
Closed
@michielbdejong
Copy link
Contributor Author

@jaxoncreed please re-review

jaxoncreed
jaxoncreed approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@jaxoncreed jaxoncreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michielbdejong
Copy link
Contributor Author

Thanks!

@michielbdejong michielbdejong merged commit d0e0821 into master Jun 13, 2019
@michielbdejong michielbdejong deleted the version-0.3 branch June 13, 2019 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pmcb55 pmcb55 pmcb55 left review comments

@jaxoncreed jaxoncreed jaxoncreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michielbdejong @pmcb55 @jaxoncreed