fix: set module: ESNext in typescript plugin #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
reviewed
Dec 18, 2023
| @@ -21,7 +21,9 @@ | |||
| import typescript from "@rollup/plugin-typescript"; | |||
|
|
|||
| export const createSharedConfig = (pkg) => ({ | |||
| plugins: [typescript()], | |||
| plugins: [typescript({ | |||
| module: 'ESNext' | |||
There was a problem hiding this comment.
In the example given in the docs, it looks like this should be wrapped in a compilerOptions map: https://github.com/rollup/plugins/tree/master/packages/typescript/#options. Do you have an example or a doc entry aligning with the way it is done here?
There was a problem hiding this comment.
The type definition allows for both; but lets go with the way the docs specify . Updated in d1541f1 and tested in inrupt/solid-client-js#2290
NSeydoux
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.