Implemented the DPoP token exchange #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77e1054:
|
Vinnl
approved these changes
Oct 12, 2020
packages/oidc-dpop-client-browser/src/dpop/tokenExchange.spec.ts
Outdated
Show resolved
Hide resolved
packages/oidc-dpop-client-browser/src/dpop/tokenExchange.spec.ts
Outdated
Show resolved
Hide resolved
packages/oidc-dpop-client-browser/src/dpop/tokenExchange.spec.ts
Outdated
Show resolved
Hide resolved
This implements the OAuth2 code exchange step: after an auth code has been returned by the IdP through redirection, the client can use the obtained auth code to get an access token. If the request has a DPoP header, the returned token is bound to the DPoP key.
NSeydoux
force-pushed
the
feat/dpop/request-token
branch
from
9d03825 to
204f15f
Compare
Co-authored-by: Vincent <[email protected]>
The mockJwk reference is unefined when setting up the mock, but the mockJwk() function is defined when *calling* the mock. Thanks @Vinnl !
Co-authored-by: Vincent <[email protected]>
The oidc module is independant from solid, so it should not depend on the core module, which is meant to be solid-specific. this implies some redundancy in the types implemented in both places, but that means that these types may evolve independantly, while still getting errors in case of incompatibility, which is a good thing.
The endpoint returns a token_type field, which can be used to verify that the token is of the requested type (Bearer or DPoP)
Importing jest requires to change the jest config, so all the modules should be updated.
pmcb55
reviewed
Oct 13, 2020
pmcb55
reviewed
Oct 13, 2020
pmcb55
reviewed
Oct 13, 2020
pmcb55
reviewed
Oct 13, 2020
pmcb55
reviewed
Oct 13, 2020
pmcb55
reviewed
Oct 13, 2020
pmcb55
reviewed
Oct 13, 2020
pmcb55
reviewed
Oct 13, 2020
pmcb55
reviewed
Oct 13, 2020
pmcb55
approved these changes
Oct 13, 2020
NSeydoux
added a commit
that referenced
this pull request
Oct 13, 2020
- This implements the OAuth2 code exchange step: after an auth code has been returned by the IdP through redirection, the client can use the obtained auth code to get an access token. If the request has a DPoP header, the returned token is bound to the DPoP key. - The mockJwk reference is unefined when setting up the mock, but the mockJwk() function is defined when *calling* the mock. Thanks @Vinnl ! - The oidc module is independant from solid, so it should not depend on the core module, which is meant to be solid-specific. this implies some redundancy in the types implemented in both places, but that means that these types may evolve independantly, while still getting errors in case of incompatibility, which is a good thing. - The endpoint returns a token_type field, which can be used to verify that the token is of the requested type (Bearer or DPoP) Co-authored-by: Vincent <[email protected]>
NSeydoux
added a commit
that referenced
this pull request
Oct 21, 2020
- This implements the OAuth2 code exchange step: after an auth code has been returned by the IdP through redirection, the client can use the obtained auth code to get an access token. If the request has a DPoP header, the returned token is bound to the DPoP key. - The mockJwk reference is unefined when setting up the mock, but the mockJwk() function is defined when *calling* the mock. Thanks @Vinnl ! - The oidc module is independant from solid, so it should not depend on the core module, which is meant to be solid-specific. this implies some redundancy in the types implemented in both places, but that means that these types may evolve independantly, while still getting errors in case of incompatibility, which is a good thing. - The endpoint returns a token_type field, which can be used to verify that the token is of the requested type (Bearer or DPoP) Co-authored-by: Vincent <[email protected]>
NSeydoux
added a commit
that referenced
this pull request
Oct 21, 2020
- This implements the OAuth2 code exchange step: after an auth code has been returned by the IdP through redirection, the client can use the obtained auth code to get an access token. If the request has a DPoP header, the returned token is bound to the DPoP key. - The mockJwk reference is unefined when setting up the mock, but the mockJwk() function is defined when *calling* the mock. Thanks @Vinnl ! - The oidc module is independant from solid, so it should not depend on the core module, which is meant to be solid-specific. this implies some redundancy in the types implemented in both places, but that means that these types may evolve independantly, while still getting errors in case of incompatibility, which is a good thing. - The endpoint returns a token_type field, which can be used to verify that the token is of the requested type (Bearer or DPoP) Co-authored-by: Vincent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the OAuth2 code exchange step: after an auth code has been returned by the IdP through redirection, the client can use the obtained auth code to get an access token. If the request has a DPoP header, the returned token is bound to the DPoP key.
index.ts, if applicable.