Skip to content

Commit

Permalink
Merge branch 'main' into dependabot/github_actions/actions/upload-art…
Browse files Browse the repository at this point in the history
…ifact-4
  • Loading branch information
NSeydoux authored Dec 19, 2023
2 parents 7d0bdcd + a9ec4db commit 05e9c0a
Show file tree
Hide file tree
Showing 30 changed files with 520 additions and 962 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-browser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
# the browser so we only need to test in one.
- uses: actions/setup-node@v4
with:
node-version: "20.x"
node-version-file: ".nvmrc"
cache: npm
- run: npm ci
if: github.actor != 'dependabot[bot]'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- environment-name: "ESS Dev-2-2"
experimental: true
# The experimental config only needs to run in one node version
node-version: "20.x"
node-version-file: ".nvmrc"
# Ditto for the OS
os: [ubuntu-latest]
steps:
Expand Down
33 changes: 19 additions & 14 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,6 @@ within this mono-repo.

This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## Deprecation notice

The following have been deprecated, and will be removed in future major releases.

### browser and node

- The `Session` class will no longer extend `EventEmitter`. Instead, it will expose
an `events` attribute implementing `EventEmitter`. We do not recommand to use
either a `Session` instance or its `events` attribute as an arbitrary events emitter,
and encourage users to only use the supported events and documented API.
- `Session` methods `onLogin`, `onLogout`, `onError`, `onSessionRestore`,
`onSessionExpiration`, `onNewRefreshToken` are deprecated in favor of `session.events.on`
called with the appropriate event name.

## Unreleased

The following changes have been implemented but not released yet:
Expand All @@ -27,6 +13,25 @@ The following changes have been implemented but not released yet:

- Use the global `fetch` function instead of `@inrupt/universal-fetch`. This means this library now only works
with Node 18 and higher.
- The `Session` class no longer extends `EventEmitter`. Instead, it exposes an `events` attribute implementing
`EventEmitter`. We do not recommand to use `Session` instance's `events` attribute as an arbitrary events emitter,
and encourage users to only use the supported events and documented API.
- `Session` methods `onLogin`, `onLogout`, `onError`, `onSessionRestore`,
`onSessionExpiration`, `onNewRefreshToken` have been removed. They are replaced by calls to `session.events.on`,
using the appropriate event name.
- `onNewRefreshToken` is no longer supported as an option to the `Session` constructor. Its usage is replaced by
calling `session.events.on` using the `EVENTS.NEW_REFRESH_TOKEN` constant as a first parameter, and a callback
handling the token as a second parameter.
- The UMD build of `@inrupt/oidc-client-ext` is no longer available. Since this is a package only intended to be
consumed by `@inrupt/solid-client-authn-browser`, which doesn't have a UMD build, this change should have no
impact.
- The `useEssSession` parameter is no longer supported by the `Session` constructor.
- The `getClientAuthenticationWithDependencies` is no longer exported as part of the public API, and is now internal-only.

### Build system changes

- Moved from `rollup-plugin-typescript2` to `@rollup/plugin-typescript`. Although this should not be a breaking change,
upgrading may require extra attention.

## [1.17.5](https://github.com/inrupt/solid-client-authn-js/releases/tag/v1.17.5) - 2023-11-16

Expand Down
2 changes: 1 addition & 1 deletion e2e/browser/solid-ui-react/test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"dependencies": {
"@inrupt/internal-playwright-testids": "^2.4.0",
"@inrupt/solid-client-authn-browser": "^1.17.5",
"@inrupt/solid-ui-react": "^2.9.0",
"@inrupt/solid-ui-react": "^2.9.1",
"next": "^14.0.4",
"react": "18.2.0",
"react-dom": "18.2.0"
Expand Down
Loading

0 comments on commit 05e9c0a

Please sign in to comment.