-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openapi examples check #2240
Merged
Merged
Openapi examples check #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfauvel
force-pushed
the
sfa/2235/openapi_examples_check
branch
2 times, most recently
from
January 22, 2025 15:05
848dfb1
to
a02e24c
Compare
Alenar
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
dlachaume
approved these changes
Jan 22, 2025
jpraynaud
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
sfauvel
force-pushed
the
sfa/2235/openapi_examples_check
branch
2 times, most recently
from
January 23, 2025 09:22
5a391dd
to
c9ec212
Compare
sfauvel
temporarily deployed
to
testing-preview
January 23, 2025 09:31 — with
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
January 23, 2025 09:31 — with
GitHub Actions
Inactive
* mithril-common from `0.4.107` to `0.4.108` * openapi.yaml from `0.1.43` to `0.1.44`
sfauvel
force-pushed
the
sfa/2235/openapi_examples_check
branch
from
January 23, 2025 09:51
c9ec212
to
829e4e4
Compare
sfauvel
temporarily deployed
to
testing-preview
January 23, 2025 10:00 — with
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
January 23, 2025 10:00 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
To be conform to the OpenAPI specification 3.1, in a previous commit we have changed
example
property toexamples
.Doing that, we have created 2 issues:
example
propertyexamples
property must contain an array of examples.This PR fix this two issues and adjust the relative path to
openapi.yaml
to generate locallyaggregator-api
with docusaurus.ApiSpec
tests are modified to take into accountexamples
property.Pre-submit checklist
Issue(s)
Closes #2235