Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runbook broken link #1539

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix runbook broken link #1539

merged 1 commit into from
Feb 27, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 27, 2024 •
edited
Loading

Content

This PR includes a fix in the new runbook after the merge of the PR #1534.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1530

@dlachaume dlachaume self-assigned this Feb 27, 2024
@dlachaume dlachaume requested a review from jpraynaud February 27, 2024 16:58
@github-actions GitHub Actions
Copy link

Test Results

  3 files  ±0   42 suites  ±0   8m 27s ⏱️ -2s
871 tests ±0  871 ✅ ±0  0 💤 ±0  0 ❌ ±0 
960 runs  ±0  960 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit aafe960. ± Comparison against base commit c31e492.

@dlachaume dlachaume temporarily deployed to testing-sanchonet February 27, 2024 17:04 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit ccd37f6 into main Feb 27, 2024
37 of 44 checks passed
@dlachaume dlachaume deleted the damien/fix-runbook-img-link branch February 27, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlachaume @jpraynaud