add pallas stake snapshots integration #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove a print statement for "computed_stake_distribution"
- simplify `get_stake_pool_hash` function by removing `stakes` argument and adjust the return type. - now fetch the `stakes.snapshot_mark_pool` directly in the `get_stake_distribution_snapshot` function when inserting into `stake_distribution`.
|
@jpraynaud ready for review |
- rename `get_stake_distribution_snapshot` to `get_stake_distribution` - change the test function name to include `with_fallback` instead of `fallback`
|
@jpraynaud done! I resent the review back to you so you can approve it :) |
dlachaume
reviewed
Feb 21, 2024
Alenar
reviewed
Feb 21, 2024
|
Nothing to say after the review. |
- refactor the filter condition in the stake snapshots loop - update `stakes` import for the changed module structure
|
Hi @falcucci, can you bump the crates versions so that we merge this PR? |
- refactor imports in `pallas_observer.rs` - update code references to `localstate::queries_v16` to now use the module specifiers directly - consolidate initialization and usage of `stakes` struct in tests - adjust stake values and pools in test data - rename `localstate::queries_v16::stakesnapshot` to `stakesnapshot` - refactor matching logic in `match` block for query handling
- update the version in cargo.toml from "0.3.4" to "0.3.5"
|
@jpraynaud done! |
falcucci
force-pushed
the
feat/stake-distribution
branch
from
5390053 to
6e3a590
Compare
falcucci
force-pushed
the
feat/stake-distribution
branch
from
6e3a590 to
311c9f4
Compare
jpraynaud
reviewed
Feb 22, 2024
Cargo.lock
Outdated
There was a problem hiding this comment.
@falcucci, actually this file should not be modified, except for the version of the mithril-common that is bumped.
Can you roll it back completely and just bump the mithril-common version?
- update the version from `0.3.6` to `0.3.7` in the `mithril-common` package metadata in `cargo.toml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submit checklist
fixes #1315