-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardano transaction sets & proof in client cli #1501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And gate it behind a `--unstable` flag.
Alenar
force-pushed
the
ensemble/1469/cardano-tx-in-client-cli
branch
from
February 13, 2024 13:26
f4aeebb
to
21705fc
Compare
Alenar
temporarily deployed
to
testing-preview
February 13, 2024 13:41 — with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
February 13, 2024 13:41 — with
GitHub Actions
Inactive
jpraynaud
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I commented for few minor typos.
docs/website/root/manual/developer-docs/nodes/mithril-client.md
Outdated
Show resolved
Hide resolved
docs/website/root/manual/developer-docs/nodes/mithril-client.md
Outdated
Show resolved
Hide resolved
docs/website/root/manual/developer-docs/nodes/mithril-client.md
Outdated
Show resolved
Hide resolved
7 tasks
Alenar
force-pushed
the
ensemble/1469/cardano-tx-in-client-cli
branch
from
February 13, 2024 15:40
2cfa4e7
to
658e162
Compare
Use the re-exported types from `mithril-client` instead.
This script will create transactions that will transfer funds from 'utx.addr' to new 'mithril-rx.addr'.
Alenar
force-pushed
the
ensemble/1469/cardano-tx-in-client-cli
branch
from
February 13, 2024 15:53
658e162
to
8e2cf21
Compare
This mistake makes this table only retains one transaction per immutable.
Alenar
force-pushed
the
ensemble/1469/cardano-tx-in-client-cli
branch
from
February 13, 2024 15:59
8e2cf21
to
f5733b6
Compare
Alenar
temporarily deployed
to
testing-preview
February 13, 2024 16:10 — with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
February 13, 2024 16:10 — with
GitHub Actions
Inactive
Alenar
force-pushed
the
ensemble/1469/cardano-tx-in-client-cli
branch
from
February 13, 2024 16:30
f5733b6
to
d393ddc
Compare
Alenar
temporarily deployed
to
testing-preview
February 13, 2024 16:47 — with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
February 13, 2024 16:47 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR implement several new commands related to the cardano transaction sets & proof in the
mithril-client-cli
:transactions sets list
commandtransactions sets show <artifact_id>
command? (if needed)transactions sets latest
commandtransactions certify <tx1>,<tx2>,...,<txn>
commandThose commands are behind a
unstable
flag that must be provided in order to activate them when running the cli.Pre-submit checklist
Comments
A problem in the transaction proof generation was detected: the order of the transactions used to generated the Merkel Root was not the same as the one used by the signable builder. The signable builder used the transactions by chronological order, the prover used them ordered by transaction hash reversed. We aligned the prover to the signable builder in order to always use the same order.
This PR also remove the dependency to
mithril-common
in themithril-client-cli
, instead it use the re-exported types frommithril-client
library.Issue(s)
Relates to #1469