Move more CI to 20.09 (attempt 2) #975

michaelpj · 2020-12-16T15:58:25Z

No description provided.

michaelpj · 2020-12-16T15:59:08Z

bors try

iohk-bors · 2020-12-16T18:53:30Z

try

Timed out.

hamishmack · 2020-12-17T01:50:32Z

bors try

hamishmack · 2020-12-17T03:38:46Z

bors try

iohk-bors · 2020-12-17T03:38:48Z

try

Already running a review

iohk-bors · 2020-12-17T03:52:00Z

try

Timed out.

hamishmack · 2020-12-17T03:52:37Z

bors try

iohk-bors · 2020-12-17T04:00:36Z

try

Build failed:

buildkite/haskell-dot-nix

hamishmack · 2020-12-17T07:52:31Z

bors try

iohk-bors · 2020-12-17T07:57:30Z

try

Build failed:

buildkite/haskell-dot-nix

hamishmack · 2020-12-17T08:04:48Z

bors try

hamishmack · 2020-12-17T09:35:44Z

bors try

iohk-bors · 2020-12-17T09:35:46Z

try

Already running a review

hamishmack · 2020-12-17T09:58:54Z

bors try

michaelpj · 2020-12-17T10:18:24Z

I'm actually not sure what's up with the emscripten problem. For one thing, the job that failed was for version 1.39.1, but the 20.09 that we're on has version 2.0.1. Strange.

This reverts commit b405cd7.

michaelpj · 2020-12-17T10:20:09Z

bors try

iohk-bors · 2020-12-17T10:20:11Z

try

Already running a review

michaelpj · 2020-12-17T10:21:13Z

Oh I see, we explicitly override the version. Mysterious.

hamishmack · 2020-12-17T10:21:41Z

The version of emscripten ghcjs 8.8 needs is the old one that came with 20.03. I have set it up to just get it from nixpkgs 20.03 for now. The plan is to update ghcjs to use the new one, but that is likely to be quite involved.

iohk-bors · 2020-12-17T10:22:19Z

try

Timed out.

michaelpj · 2020-12-17T10:22:22Z

We should add a comment before we merge, at least!

michaelpj · 2020-12-17T10:22:35Z

bors try

iohk-bors · 2020-12-17T11:01:34Z

try

Build succeeded:

hamishmack · 2020-12-17T11:04:23Z

bors try

iohk-bors · 2020-12-17T12:34:59Z

try

Build succeeded:

hamishmack · 2020-12-17T12:48:17Z

bors try

michaelpj · 2020-12-17T13:57:04Z

ci.nix

-  } // lib.optionalAttrs (system == "x86_64-linux" && (nixpkgsName == "R2009" || (!(__elem compiler-nix-name ["ghc8101" "ghc8102" "ghc810220201118"])))) {
+  } // lib.optionalAttrs (system == "x86_64-linux" && (
+         (nixpkgsName == "R2009" && __elem compiler-nix-name ["ghc8101" "ghc8102" "ghc810220201118"])
+      || (nixpkgsName == "R2003" && __elem compiler-nix-name ["ghc865"]))) {


I'm not sure this change matches the commit message? This turns off 8.10 + 20.09 and 8.6.5 + 20.03, is that what you meant to do?

Ignore me, I can't read.

michaelpj · 2020-12-17T14:00:59Z

ci.nix

@@ -42,9 +40,11 @@
    # We need to use the actual nixpkgs version we're working with here, since the values
    # of 'lib.systems.examples' are not understood between all versions
    let lib = nixpkgs.lib;
-    in lib.optionalAttrs (nixpkgsName == "R2003" && (__elem compiler-nix-name ["ghc865" "ghc884"])) {
+    in lib.optionalAttrs (nixpkgsName == "R2009" && (__elem compiler-nix-name ["ghc865" "ghc884"])) {


Maybe we should flip this and only run ghcjs tests on a particular chosen GHC version. IDK.

I also can't read here (for some reason I thought this was !elem)

michaelpj · 2020-12-17T14:24:18Z

I think some more GHCJS tests are failing because we're building on more versions of GHC. I have a plan for dealing with "expected fail" tests better (PR following this one), but for now I think it's okay.

iohk-bors · 2020-12-17T14:52:49Z

try

Timed out.

michaelpj · 2020-12-17T15:02:09Z

Updated the supported versions doc with a more comprehensive table.

michaelpj · 2020-12-17T15:02:17Z

I think this is good to go, will merge in a bit.

* Update default nixpkgs to 20.09 * Move more CI to work on 20.09 by default * IFD level 1 * Use nixpkgs 20.03 emscripten (needed for ghcjs) * Add missing materialized files * Add missing materialized files * Fix for ghc 8.8 build on darwin * Fix for ghcjs 8.8 build on darwin * Fix hls stack test eval for ghc810220201118 * ifdLevel 2 * Oops: accidentally turned on tests for experimental GHC * Revert "Fix hls stack test eval for ghc810220201118" This reverts commit b405cd7. * ifdLevel 3 * Disable GHC 8.6.5 windows cross on nixpkgs 20.09 * Update supported GHC doc with a table * Add emscripten comment Co-authored-by: Hamish Mackenzie <[email protected]>

michaelpj added 3 commits December 16, 2020 15:19

Update default nixpkgs to 20.09

f7f7bf1

Move more CI to work on 20.09 by default

3446d2e

IFD level 1

524c4f4

iohk-bors bot added a commit that referenced this pull request Dec 16, 2020

Try #975:

c2bef5b

hamishmack added 2 commits December 17, 2020 14:33

Use nixpkgs 20.03 emscripten (needed for ghcjs)

9b4184c

Add missing materialized files

0bcedfe

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020

Try #975:

a51ab09

hamishmack added 2 commits December 17, 2020 16:16

Add missing materialized files

7ec06f8

Fix for ghc 8.8 build on darwin

8a185f0

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020

Try #975:

c55da9b

Fix for ghcjs 8.8 build on darwin

1accb2c

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020

Try #975:

311d2ff

Fix hls stack test eval for ghc810220201118

b405cd7

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020

Try #975:

f0f14fb

hamishmack mentioned this pull request Dec 17, 2020

Add missing materialized ghc 8.10 windows files #954

Closed

ifdLevel 2

a805b6e

michaelpj added 2 commits December 17, 2020 10:19

Oops: accidentally turned on tests for experimental GHC

7ab55f6

Revert "Fix hls stack test eval for ghc810220201118"

bd2b99b

This reverts commit b405cd7.

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020

Try #975:

a838ec8

ifdLevel 3

5a70a4e

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020

Try #975:

575f9da

Disable GHC 8.6.5 windows cross on nixpkgs 20.09

565b31f

iohk-bors bot added a commit that referenced this pull request Dec 17, 2020

Try #975:

10e0a3a

michaelpj commented Dec 17, 2020

View reviewed changes

Update supported GHC doc with a table

05ba746

Add emscripten comment

e6f2a28

michaelpj merged commit 738af22 into master Dec 17, 2020

iohk-bors bot deleted the imp/more-2009-ci branch December 17, 2020 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move more CI to 20.09 (attempt 2) #975

Move more CI to 20.09 (attempt 2) #975

michaelpj commented Dec 16, 2020

michaelpj commented Dec 16, 2020

iohk-bors bot commented Dec 16, 2020

hamishmack commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

hamishmack commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

hamishmack commented Dec 17, 2020

michaelpj commented Dec 17, 2020

michaelpj commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

michaelpj commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

michaelpj commented Dec 17, 2020

michaelpj commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

hamishmack commented Dec 17, 2020

michaelpj Dec 17, 2020

michaelpj Dec 17, 2020

michaelpj Dec 17, 2020

michaelpj Dec 17, 2020

michaelpj commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

michaelpj commented Dec 17, 2020

michaelpj commented Dec 17, 2020

Move more CI to 20.09 (attempt 2) #975

Move more CI to 20.09 (attempt 2) #975

Conversation

michaelpj commented Dec 16, 2020

michaelpj commented Dec 16, 2020

iohk-bors bot commented Dec 16, 2020

try

hamishmack commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

iohk-bors bot commented Dec 17, 2020

try

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

hamishmack commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

hamishmack commented Dec 17, 2020

michaelpj commented Dec 17, 2020

michaelpj commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

michaelpj commented Dec 17, 2020

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

michaelpj commented Dec 17, 2020

michaelpj commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

hamishmack commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

hamishmack commented Dec 17, 2020

michaelpj Dec 17, 2020

Choose a reason for hiding this comment

michaelpj Dec 17, 2020

Choose a reason for hiding this comment

michaelpj Dec 17, 2020

Choose a reason for hiding this comment

michaelpj Dec 17, 2020

Choose a reason for hiding this comment

michaelpj commented Dec 17, 2020

iohk-bors bot commented Dec 17, 2020

try

michaelpj commented Dec 17, 2020

michaelpj commented Dec 17, 2020