Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Review Buildable Instances #316

Merged
merged 4 commits into from
Feb 7, 2019
Merged

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Feb 6, 2019

#315

Overview

  • I have added a couple of extra utils to more easily write Buildable instances that are useful
  • I have changed a couple of existing Buildable instance to favor readability and output more information

Comments

@KtorZ KtorZ self-assigned this Feb 6, 2019
@KtorZ KtorZ requested a review from denisshevchenko February 6, 2019 11:39
@denisshevchenko denisshevchenko mentioned this pull request Feb 6, 2019
11 tasks
Copy link
Contributor

@denisshevchenko denisshevchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure that now our logs will be much prettier!

@KtorZ KtorZ force-pushed the KtorZ/review-buildable-instances branch from ef154ed to 71f9ebd Compare February 7, 2019 10:20
@KtorZ KtorZ merged commit 935e9c5 into develop Feb 7, 2019
@KtorZ KtorZ deleted the KtorZ/review-buildable-instances branch February 7, 2019 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants