Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

unlock dumper on exception #4213

Merged
merged 1 commit into from
Aug 1, 2019
Merged

unlock dumper on exception #4213

merged 1 commit into from
Aug 1, 2019

Conversation

disassembler
Copy link
Contributor

Description

Minor fix to allow dumper to continue after failed imports

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CBR-530

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

@johnalotoski
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 1, 2019
4213: unlock dumper on exception r=johnalotoski a=disassembler

## Description

Minor fix to allow dumper to continue after failed imports

## Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-530
<!--- Put here the relevant issue from YouTrack -->



Co-authored-by: Samuel Leathers <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 1, 2019

@iohk-bors iohk-bors bot merged commit bb360a0 into develop Aug 1, 2019
@iohk-bors iohk-bors bot deleted the explorer-python-api-2 branch August 1, 2019 16:23
@disassembler disassembler mentioned this pull request Aug 1, 2019
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants