feat(apollo): Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-to-be-able-to-use-castor-to-verify-a-signature # Conflicts: # castor/Castor.ts # tests/castor/PrismDID.test.ts
… replace with Buffer.from(*.toArray)
…from apollo directly.
elribonazo
requested review from
milosh86,
curtis-h,
igdev0,
goncalo-frade-iohk,
amagyar-iohk and
cristianIOHK
Co-authored-by: goncalo-frade-iohk <[email protected]>
Co-authored-by: goncalo-frade-iohk <[email protected]>
goncalo-frade-iohk
approved these changes
Mar 6, 2023
atala-dev
added a commit
that referenced
this pull request
Mar 28, 2023
# [2.0.0](v1.0.0...v2.0.0) (2023-03-28) ### Bug Fixes * **apollo:** fix typo in public method ([#15](#15)) ([59cd862](59cd862)) * **apollo:** throw error when signing with x25519 ([#16](#16)) ([6371d27](6371d27)) * browser webpack issue ([#29](#29)) ([02d186e](02d186e)) * Browser webpack issue ([#30](#30)) ([8c59450](8c59450)) * pluto table recreate attempt ([#34](#34)) ([3a011cb](3a011cb)) * **pluto:** usage on agent & other minor updates ([#27](#27)) ([2a18d14](2a18d14)) * react-native-sqlite-storage complain ([#32](#32)) ([9ca0ad3](9ca0ad3)) * Webpack dev server infinite loop ([#33](#33)) ([94eb991](94eb991)) ### Continuous Integration * add semantic-release ([617c64a](617c64a)) ### Features * **agent:** Implement agent with basic mediation protocol, with examples ([#23](#23)) ([b0104b2](b0104b2)) * **agent:** Implementing DIDComm V2 Protocols + Demo showcasing ([#36](#36)) ([515d835](515d835)) * **apollo:** Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. ([#13](#13)) ([f6eabef](f6eabef)) * ATL 3641 - Pluto in wallet implementation ([#17](#17)) ([54579e5](54579e5)) * **examples:** add browser sdk integration example - keys and dids ([#14](#14)) ([4cd0e75](4cd0e75)) * **examples:** adding agent control buttons to browser demo ([#24](#24)) ([696309d](696309d)) * **examples:** initial examples setup + build config update ([#8](#8)) ([0b6ec28](0b6ec28)) * Pluto typeorm migration. ([#22](#22)) ([6107ef2](6107ef2)) * **Pollux:** Implementing Pollux.parseVerifiableCredential with tests ([#4](#4)) ([da05e65](da05e65)) * **testing:** Add Karma testing for browser ([#9](#9)) ([b15f148](b15f148)) ### BREAKING CHANGES * release Atala V2
atala-dev
added a commit
that referenced
this pull request
Apr 4, 2023
# [2.0.0](v1.0.0...v2.0.0) (2023-04-04) ### Bug Fixes * **apollo:** fix typo in public method ([#15](#15)) ([59cd862](59cd862)) * **apollo:** throw error when signing with x25519 ([#16](#16)) ([6371d27](6371d27)) * browser webpack issue ([#29](#29)) ([02d186e](02d186e)) * Browser webpack issue ([#30](#30)) ([8c59450](8c59450)) * move required libs to dependencies instead of devDependencies ([#39](#39)) ([7a7716f](7a7716f)) * parse timestamp to date ([#43](#43)) ([0eb0cc6](0eb0cc6)) * pluto table recreate attempt ([#34](#34)) ([3a011cb](3a011cb)) * **pluto:** usage on agent & other minor updates ([#27](#27)) ([2a18d14](2a18d14)) * react-native-sqlite-storage complain ([#32](#32)) ([9ca0ad3](9ca0ad3)) * typeorm cleanup ([#40](#40)) ([f8765a9](f8765a9)) * Webpack dev server infinite loop ([#33](#33)) ([94eb991](94eb991)) ### Continuous Integration * add semantic-release ([617c64a](617c64a)) ### Features * **agent:** Implement agent with basic mediation protocol, with examples ([#23](#23)) ([b0104b2](b0104b2)) * **agent:** Implementing DIDComm V2 Protocols + Demo showcasing ([#36](#36)) ([515d835](515d835)) * **apollo:** Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. ([#13](#13)) ([f6eabef](f6eabef)) * ATL 3641 - Pluto in wallet implementation ([#17](#17)) ([54579e5](54579e5)) * **examples:** add browser sdk integration example - keys and dids ([#14](#14)) ([4cd0e75](4cd0e75)) * **examples:** adding agent control buttons to browser demo ([#24](#24)) ([696309d](696309d)) * **examples:** initial examples setup + build config update ([#8](#8)) ([0b6ec28](0b6ec28)) * Pluto typeorm migration. ([#22](#22)) ([6107ef2](6107ef2)) * **Pollux:** Implementing Pollux.parseVerifiableCredential with tests ([#4](#4)) ([da05e65](da05e65)) * **testing:** Add Karma testing for browser ([#9](#9)) ([b15f148](b15f148)) ### BREAKING CHANGES * release Atala V2
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
…KeyAgreement and Authentication. (hyperledger#13) Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
# [2.0.0](hyperledger/identus-edge-agent-sdk-ts@v1.0.0...v2.0.0) (2023-03-28) ### Bug Fixes * **apollo:** fix typo in public method ([hyperledger#15](hyperledger#15)) ([59cd862](hyperledger@59cd862)) * **apollo:** throw error when signing with x25519 ([hyperledger#16](hyperledger#16)) ([6371d27](hyperledger@6371d27)) * browser webpack issue ([hyperledger#29](hyperledger#29)) ([02d186e](hyperledger@02d186e)) * Browser webpack issue ([hyperledger#30](hyperledger#30)) ([8c59450](hyperledger@8c59450)) * pluto table recreate attempt ([hyperledger#34](hyperledger#34)) ([3a011cb](hyperledger@3a011cb)) * **pluto:** usage on agent & other minor updates ([hyperledger#27](hyperledger#27)) ([2a18d14](hyperledger@2a18d14)) * react-native-sqlite-storage complain ([hyperledger#32](hyperledger#32)) ([9ca0ad3](hyperledger@9ca0ad3)) * Webpack dev server infinite loop ([hyperledger#33](hyperledger#33)) ([94eb991](hyperledger@94eb991)) ### Continuous Integration * add semantic-release ([617c64a](hyperledger@617c64a)) ### Features * **agent:** Implement agent with basic mediation protocol, with examples ([hyperledger#23](hyperledger#23)) ([b0104b2](hyperledger@b0104b2)) * **agent:** Implementing DIDComm V2 Protocols + Demo showcasing ([hyperledger#36](hyperledger#36)) ([515d835](hyperledger@515d835)) * **apollo:** Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. ([hyperledger#13](hyperledger#13)) ([f6eabef](hyperledger@f6eabef)) * ATL 3641 - Pluto in wallet implementation ([hyperledger#17](hyperledger#17)) ([54579e5](hyperledger@54579e5)) * **examples:** add browser sdk integration example - keys and dids ([hyperledger#14](hyperledger#14)) ([4cd0e75](hyperledger@4cd0e75)) * **examples:** adding agent control buttons to browser demo ([hyperledger#24](hyperledger#24)) ([696309d](hyperledger@696309d)) * **examples:** initial examples setup + build config update ([hyperledger#8](hyperledger#8)) ([0b6ec28](hyperledger@0b6ec28)) * Pluto typeorm migration. ([hyperledger#22](hyperledger#22)) ([6107ef2](hyperledger@6107ef2)) * **Pollux:** Implementing Pollux.parseVerifiableCredential with tests ([hyperledger#4](hyperledger#4)) ([da05e65](hyperledger@da05e65)) * **testing:** Add Karma testing for browser ([hyperledger#9](hyperledger#9)) ([b15f148](hyperledger@b15f148)) ### BREAKING CHANGES * release Atala V2 Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
# [2.0.0](hyperledger/identus-edge-agent-sdk-ts@v1.0.0...v2.0.0) (2023-04-04) ### Bug Fixes * **apollo:** fix typo in public method ([hyperledger#15](hyperledger#15)) ([59cd862](hyperledger@59cd862)) * **apollo:** throw error when signing with x25519 ([hyperledger#16](hyperledger#16)) ([6371d27](hyperledger@6371d27)) * browser webpack issue ([hyperledger#29](hyperledger#29)) ([02d186e](hyperledger@02d186e)) * Browser webpack issue ([hyperledger#30](hyperledger#30)) ([8c59450](hyperledger@8c59450)) * move required libs to dependencies instead of devDependencies ([hyperledger#39](hyperledger#39)) ([7a7716f](hyperledger@7a7716f)) * parse timestamp to date ([hyperledger#43](hyperledger#43)) ([0eb0cc6](hyperledger@0eb0cc6)) * pluto table recreate attempt ([hyperledger#34](hyperledger#34)) ([3a011cb](hyperledger@3a011cb)) * **pluto:** usage on agent & other minor updates ([hyperledger#27](hyperledger#27)) ([2a18d14](hyperledger@2a18d14)) * react-native-sqlite-storage complain ([hyperledger#32](hyperledger#32)) ([9ca0ad3](hyperledger@9ca0ad3)) * typeorm cleanup ([hyperledger#40](hyperledger#40)) ([f8765a9](hyperledger@f8765a9)) * Webpack dev server infinite loop ([hyperledger#33](hyperledger#33)) ([94eb991](hyperledger@94eb991)) ### Continuous Integration * add semantic-release ([617c64a](hyperledger@617c64a)) ### Features * **agent:** Implement agent with basic mediation protocol, with examples ([hyperledger#23](hyperledger#23)) ([b0104b2](hyperledger@b0104b2)) * **agent:** Implementing DIDComm V2 Protocols + Demo showcasing ([hyperledger#36](hyperledger#36)) ([515d835](hyperledger@515d835)) * **apollo:** Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. ([hyperledger#13](hyperledger#13)) ([f6eabef](hyperledger@f6eabef)) * ATL 3641 - Pluto in wallet implementation ([hyperledger#17](hyperledger#17)) ([54579e5](hyperledger@54579e5)) * **examples:** add browser sdk integration example - keys and dids ([hyperledger#14](hyperledger#14)) ([4cd0e75](hyperledger@4cd0e75)) * **examples:** adding agent control buttons to browser demo ([hyperledger#24](hyperledger#24)) ([696309d](hyperledger@696309d)) * **examples:** initial examples setup + build config update ([hyperledger#8](hyperledger#8)) ([0b6ec28](hyperledger@0b6ec28)) * Pluto typeorm migration. ([hyperledger#22](hyperledger#22)) ([6107ef2](hyperledger@6107ef2)) * **Pollux:** Implementing Pollux.parseVerifiableCredential with tests ([hyperledger#4](hyperledger#4)) ([da05e65](hyperledger@da05e65)) * **testing:** Add Karma testing for browser ([hyperledger#9](hyperledger#9)) ([b15f148](hyperledger@b15f148)) ### BREAKING CHANGES * release Atala V2 Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was intended to be something really smaller, @cristianIOHK was about to complete the verification method in castor but he couldn't make it work.
I jumped in and started fixing secp256K1 ecdsa we had and made it work with protos, etc + unit testing.
Have delivered a working version of ed25519 and eddsa with same libraries we used in the past (Elliptic)
And lately, have also added ECDH with curve25519 (X25519)
Minimal testing coverage but we are getting a lot better here to be honest! Let's go team!
Checklist