Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples): add browser sdk integration example - keys and dids #14

Merged
merged 16 commits into from
Mar 10, 2023
Merged

feat(examples): add browser sdk integration example - keys and dids #14

merged 16 commits into from
Mar 10, 2023

Conversation

milosh86
Copy link
Contributor

@milosh86 milosh86 commented Mar 6, 2023 •
edited
Loading

Description

Created example web app integrating wallet sdk.
To be easier, I added examples folder to this repo for now, but we can change it if needed later.

I don't see this examples as something we would share directly with users, but rather:

  1. a tool for us to go through and test most important flows (until we have solid test suite)
  2. an input to dev docs - we can use this to create dev docs and code examples

Jira link

https://input-output.atlassian.net/browse/ATL-3718
https://input-output.atlassian.net/browse/ATL-3716

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

@milosh86 milosh86 changed the title [WIP] feat(examples): add browser sdk integration example - keys and dids feat(examples): add browser sdk integration example - keys and dids Mar 7, 2023
@milosh86 milosh86 marked this pull request as ready for review March 7, 2023 11:24
@milosh86 milosh86 requested a review from elribonazo March 7, 2023 11:26
@elribonazo
Copy link
Contributor

Awesome!

@elribonazo
Copy link
Contributor

elribonazo commented Mar 7, 2023 •
edited
Loading

@milosh86 should we try and expose our base64 from multibase/bases/base64.
If our package exported this

import {base64url} from "multibase/bases/base64". We could use baseEncode or baseDecode. Maybe we can add it for future improvements dunno.

We are soon going to add this package too so i don't see a huge problem.

@milosh86
Copy link
Contributor Author

milosh86 commented Mar 7, 2023

@elribonazo I am not sure, it would be nice to have base64Url encode/decode available as it is required in some cases, but on the other hand it's ok to just recommend an external library for that.

elribonazo
elribonazo approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@elribonazo elribonazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve but please add everyone else you can to the PR's to approve them faster :) also for visibility.

Thanks sir!

@milosh86 milosh86 merged commit 4cd0e75 into master Mar 10, 2023
@milosh86 milosh86 deleted the ATL-3718-example-keys-and-DIDs branch March 10, 2023 09:13
atala-dev added a commit that referenced this pull request Mar 28, 2023
@atala-dev
chore(release): release 2.0.0
f7aa5cf 
# [2.0.0](v1.0.0...v2.0.0) (2023-03-28)

### Bug Fixes

* **apollo:** fix typo in public method ([#15](#15)) ([59cd862](59cd862))
* **apollo:** throw error when signing with x25519 ([#16](#16)) ([6371d27](6371d27))
* browser webpack issue ([#29](#29)) ([02d186e](02d186e))
* Browser webpack issue ([#30](#30)) ([8c59450](8c59450))
* pluto table recreate attempt ([#34](#34)) ([3a011cb](3a011cb))
* **pluto:** usage on agent & other minor updates ([#27](#27)) ([2a18d14](2a18d14))
* react-native-sqlite-storage complain ([#32](#32)) ([9ca0ad3](9ca0ad3))
* Webpack dev server infinite loop ([#33](#33)) ([94eb991](94eb991))

### Continuous Integration

* add semantic-release ([617c64a](617c64a))

### Features

* **agent:** Implement agent with basic mediation protocol, with examples ([#23](#23)) ([b0104b2](b0104b2))
* **agent:** Implementing DIDComm V2 Protocols + Demo showcasing ([#36](#36)) ([515d835](515d835))
* **apollo:** Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. ([#13](#13)) ([f6eabef](f6eabef))
* ATL 3641 - Pluto in wallet implementation ([#17](#17)) ([54579e5](54579e5))
* **examples:** add browser sdk integration example - keys and dids ([#14](#14)) ([4cd0e75](4cd0e75))
* **examples:** adding agent control buttons to browser demo ([#24](#24)) ([696309d](696309d))
* **examples:** initial examples setup + build config update ([#8](#8)) ([0b6ec28](0b6ec28))
* Pluto typeorm migration. ([#22](#22)) ([6107ef2](6107ef2))
* **Pollux:** Implementing Pollux.parseVerifiableCredential with tests ([#4](#4)) ([da05e65](da05e65))
* **testing:** Add Karma testing for browser ([#9](#9)) ([b15f148](b15f148))

### BREAKING CHANGES

* release Atala V2
atala-dev added a commit that referenced this pull request Apr 4, 2023
@atala-dev
chore(release): release 2.0.0
77fcc8c 
# [2.0.0](v1.0.0...v2.0.0) (2023-04-04)

### Bug Fixes

* **apollo:** fix typo in public method ([#15](#15)) ([59cd862](59cd862))
* **apollo:** throw error when signing with x25519 ([#16](#16)) ([6371d27](6371d27))
* browser webpack issue ([#29](#29)) ([02d186e](02d186e))
* Browser webpack issue ([#30](#30)) ([8c59450](8c59450))
* move required libs to dependencies instead of devDependencies ([#39](#39)) ([7a7716f](7a7716f))
* parse timestamp to date ([#43](#43)) ([0eb0cc6](0eb0cc6))
* pluto table recreate attempt ([#34](#34)) ([3a011cb](3a011cb))
* **pluto:** usage on agent & other minor updates ([#27](#27)) ([2a18d14](2a18d14))
* react-native-sqlite-storage complain ([#32](#32)) ([9ca0ad3](9ca0ad3))
* typeorm cleanup ([#40](#40)) ([f8765a9](f8765a9))
* Webpack dev server infinite loop ([#33](#33)) ([94eb991](94eb991))

### Continuous Integration

* add semantic-release ([617c64a](617c64a))

### Features

* **agent:** Implement agent with basic mediation protocol, with examples ([#23](#23)) ([b0104b2](b0104b2))
* **agent:** Implementing DIDComm V2 Protocols + Demo showcasing ([#36](#36)) ([515d835](515d835))
* **apollo:** Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. ([#13](#13)) ([f6eabef](f6eabef))
* ATL 3641 - Pluto in wallet implementation ([#17](#17)) ([54579e5](54579e5))
* **examples:** add browser sdk integration example - keys and dids ([#14](#14)) ([4cd0e75](4cd0e75))
* **examples:** adding agent control buttons to browser demo ([#24](#24)) ([696309d](696309d))
* **examples:** initial examples setup + build config update ([#8](#8)) ([0b6ec28](0b6ec28))
* Pluto typeorm migration. ([#22](#22)) ([6107ef2](6107ef2))
* **Pollux:** Implementing Pollux.parseVerifiableCredential with tests ([#4](#4)) ([da05e65](da05e65))
* **testing:** Add Karma testing for browser ([#9](#9)) ([b15f148](b15f148))

### BREAKING CHANGES

* release Atala V2
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
@milosh86 @elribonazo
feat(examples): add browser sdk integration example - keys and dids (h…
45bba1a 
…yperledger#14)

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
@atala-dev @elribonazo
chore(release): release 2.0.0
472e450 
# [2.0.0](hyperledger/identus-edge-agent-sdk-ts@v1.0.0...v2.0.0) (2023-03-28)

### Bug Fixes

* **apollo:** fix typo in public method ([hyperledger#15](hyperledger#15)) ([59cd862](hyperledger@59cd862))
* **apollo:** throw error when signing with x25519 ([hyperledger#16](hyperledger#16)) ([6371d27](hyperledger@6371d27))
* browser webpack issue ([hyperledger#29](hyperledger#29)) ([02d186e](hyperledger@02d186e))
* Browser webpack issue ([hyperledger#30](hyperledger#30)) ([8c59450](hyperledger@8c59450))
* pluto table recreate attempt ([hyperledger#34](hyperledger#34)) ([3a011cb](hyperledger@3a011cb))
* **pluto:** usage on agent & other minor updates ([hyperledger#27](hyperledger#27)) ([2a18d14](hyperledger@2a18d14))
* react-native-sqlite-storage complain ([hyperledger#32](hyperledger#32)) ([9ca0ad3](hyperledger@9ca0ad3))
* Webpack dev server infinite loop ([hyperledger#33](hyperledger#33)) ([94eb991](hyperledger@94eb991))

### Continuous Integration

* add semantic-release ([617c64a](hyperledger@617c64a))

### Features

* **agent:** Implement agent with basic mediation protocol, with examples ([hyperledger#23](hyperledger#23)) ([b0104b2](hyperledger@b0104b2))
* **agent:** Implementing DIDComm V2 Protocols + Demo showcasing ([hyperledger#36](hyperledger#36)) ([515d835](hyperledger@515d835))
* **apollo:** Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. ([hyperledger#13](hyperledger#13)) ([f6eabef](hyperledger@f6eabef))
* ATL 3641 - Pluto in wallet implementation ([hyperledger#17](hyperledger#17)) ([54579e5](hyperledger@54579e5))
* **examples:** add browser sdk integration example - keys and dids ([hyperledger#14](hyperledger#14)) ([4cd0e75](hyperledger@4cd0e75))
* **examples:** adding agent control buttons to browser demo ([hyperledger#24](hyperledger#24)) ([696309d](hyperledger@696309d))
* **examples:** initial examples setup + build config update ([hyperledger#8](hyperledger#8)) ([0b6ec28](hyperledger@0b6ec28))
* Pluto typeorm migration. ([hyperledger#22](hyperledger#22)) ([6107ef2](hyperledger@6107ef2))
* **Pollux:** Implementing Pollux.parseVerifiableCredential with tests ([hyperledger#4](hyperledger#4)) ([da05e65](hyperledger@da05e65))
* **testing:** Add Karma testing for browser ([hyperledger#9](hyperledger#9)) ([b15f148](hyperledger@b15f148))

### BREAKING CHANGES

* release Atala V2

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
@atala-dev @elribonazo
chore(release): release 2.0.0
c583b37 
# [2.0.0](hyperledger/identus-edge-agent-sdk-ts@v1.0.0...v2.0.0) (2023-04-04)

### Bug Fixes

* **apollo:** fix typo in public method ([hyperledger#15](hyperledger#15)) ([59cd862](hyperledger@59cd862))
* **apollo:** throw error when signing with x25519 ([hyperledger#16](hyperledger#16)) ([6371d27](hyperledger@6371d27))
* browser webpack issue ([hyperledger#29](hyperledger#29)) ([02d186e](hyperledger@02d186e))
* Browser webpack issue ([hyperledger#30](hyperledger#30)) ([8c59450](hyperledger@8c59450))
* move required libs to dependencies instead of devDependencies ([hyperledger#39](hyperledger#39)) ([7a7716f](hyperledger@7a7716f))
* parse timestamp to date ([hyperledger#43](hyperledger#43)) ([0eb0cc6](hyperledger@0eb0cc6))
* pluto table recreate attempt ([hyperledger#34](hyperledger#34)) ([3a011cb](hyperledger@3a011cb))
* **pluto:** usage on agent & other minor updates ([hyperledger#27](hyperledger#27)) ([2a18d14](hyperledger@2a18d14))
* react-native-sqlite-storage complain ([hyperledger#32](hyperledger#32)) ([9ca0ad3](hyperledger@9ca0ad3))
* typeorm cleanup ([hyperledger#40](hyperledger#40)) ([f8765a9](hyperledger@f8765a9))
* Webpack dev server infinite loop ([hyperledger#33](hyperledger#33)) ([94eb991](hyperledger@94eb991))

### Continuous Integration

* add semantic-release ([617c64a](hyperledger@617c64a))

### Features

* **agent:** Implement agent with basic mediation protocol, with examples ([hyperledger#23](hyperledger#23)) ([b0104b2](hyperledger@b0104b2))
* **agent:** Implementing DIDComm V2 Protocols + Demo showcasing ([hyperledger#36](hyperledger#36)) ([515d835](hyperledger@515d835))
* **apollo:** Implementing PeerDID ED25519 and X25519 algorithms for KeyAgreement and Authentication. ([hyperledger#13](hyperledger#13)) ([f6eabef](hyperledger@f6eabef))
* ATL 3641 - Pluto in wallet implementation ([hyperledger#17](hyperledger#17)) ([54579e5](hyperledger@54579e5))
* **examples:** add browser sdk integration example - keys and dids ([hyperledger#14](hyperledger#14)) ([4cd0e75](hyperledger@4cd0e75))
* **examples:** adding agent control buttons to browser demo ([hyperledger#24](hyperledger#24)) ([696309d](hyperledger@696309d))
* **examples:** initial examples setup + build config update ([hyperledger#8](hyperledger#8)) ([0b6ec28](hyperledger@0b6ec28))
* Pluto typeorm migration. ([hyperledger#22](hyperledger#22)) ([6107ef2](hyperledger@6107ef2))
* **Pollux:** Implementing Pollux.parseVerifiableCredential with tests ([hyperledger#4](hyperledger#4)) ([da05e65](hyperledger@da05e65))
* **testing:** Add Karma testing for browser ([hyperledger#9](hyperledger#9)) ([b15f148](hyperledger@b15f148))

### BREAKING CHANGES

* release Atala V2

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elribonazo elribonazo elribonazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milosh86 @elribonazo