Require PHP 7.4, Fix CS and QA #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PHPCS was not checked due to wrong configuration. Fix config (to latest Inpsyde CS) and the fix code - Use typed properties when possible - Use doc bloc consistently, delete unnecessary comments - Update dependencies and GHA workflow (no need to support PHPUnit 8) - Added Package::STATUS_BOOTING constant to alias Package::STATUS_MODULES_ADDED for clarity
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
============================================
- Coverage 98.97% 98.93% -0.04%
- Complexity 217 234 +17
============================================
Files 10 10
Lines 588 566 -22
============================================
- Hits 582 560 -22
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Chrico
reviewed
May 24, 2024
Chrico
reviewed
May 24, 2024
tfrommen
approved these changes
May 24, 2024
|
Thanks for the review and the added test @tfrommen |
Chrico
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix (for PHPCS config) + maintenance update
What is the current behavior? (You can also link to an open issue here)
PHPCS did not check anything.
What is the new behavior (if this is a feature change)?
No change in behavior. PHPCS now works (besides being updated).
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: