Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mock system time for snowfall #4760

Merged
merged 2 commits into from
Jan 13, 2025
Merged

test: mock system time for snowfall #4760

merged 2 commits into from
Jan 13, 2025

Conversation

Schwehn42
Copy link
Member

Description

In the months of December and January, snowfall is rendered including a setting in the Appearance component.
An accompanying test would compare the rendered component to a snapshot. However, since the test is reliant on time, the test will fail if the time's not right. Additionally, CI/CD runners don't necessarily synchronize their time with the real world, leading to more confusion. Hence, these tests mock the system time in order to achieve consistent results.

Changelog

  • Appearance.test.tsx
    • set mocked system time
    • add test to test both with and without snowfall
  • Appearance.test.tsx.snap: update snapshot

renders with/without snowfall
@Schwehn42 Schwehn42 self-assigned this Jan 10, 2025
@Schwehn42 Schwehn42 changed the title test: mock system time test: mock system time for snowfall Jan 10, 2025

This comment has been minimized.

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4760.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-92ec167

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-92ec167

Copy link

octomind-dev bot commented Jan 13, 2025

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 92ec167

@Schwehn42 Schwehn42 added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit fd20526 Jan 13, 2025
12 checks passed
@Schwehn42 Schwehn42 deleted the js/mock-snowfall-dates branch January 13, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants