Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add session secret env var check #4709

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

Planlos5000
Copy link
Contributor

Add documentation for the SESSION_SECRET env var.
Also add a check if the variable is set if an authentication provider is configured.
Add SESSION_SECRET to the docker compose.

Description

Add the documentaion for the SESSION_SECRET environment variable.
Also add a check if the SESSION_SECRET is set if an authentication provider is set.

Changelog

Add documentation for the SESSION_SECRET env var.
Add check if the variable is set if an authentication provider is configured.
Add SESSION_SECRET to the docker compose.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@Planlos5000 Planlos5000 linked an issue Dec 17, 2024 that may be closed by this pull request
@Planlos5000 Planlos5000 force-pushed the fs/docs_session_store branch from 31338ce to 1b2b0f6 Compare December 18, 2024 08:54
@Schwehn42 Schwehn42 added Changes Requested Changes requested by the reviewer and removed Changes Requested Changes requested by the reviewer labels Dec 18, 2024
Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🙏

@Planlos5000 Planlos5000 force-pushed the fs/docs_session_store branch from 1b2b0f6 to fde5fc5 Compare December 18, 2024 13:01
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4709.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-db3e11d

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-db3e11d

Copy link

octomind-dev bot commented Dec 18, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: db3e11d

@Planlos5000 Planlos5000 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit cc04e1d Dec 19, 2024
13 checks passed
@Planlos5000 Planlos5000 deleted the fs/docs_session_store branch December 19, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Secret docs
2 participants