-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the actions of votes when different events are triggered #4616
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still have plans to change the backend so only the most recent voting is sent or should we just leave it as is for now?
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I've found one last edge case: During an active voting, deleting a note doesn't delete the votes associated with it.
I would guess that the votes are deleting in the backend, since the deletion cascades, but the frontend doesn't remove the votes just by the event.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The deployment to the dev cluster was successful. You can find the deployment here: https://4616.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 14/14 successful.
commit sha: 67beeda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be working now, amazing and thank you ❤️
Description
The problem was that if a user re-joins the board during a vote, they lose all votes except their own.
The reason for this is that the
Fullboard
method only queries the votes that the user has created.Changelog
Backend
boards/boards.go
api/event-filter
Frontend
votes/reducer
votings/reducer
Checklist
(Optional) Visual Changes