Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve tab navigation issue in Firefox #4562

Merged
merged 7 commits into from
Nov 8, 2024
Merged

fix: Resolve tab navigation issue in Firefox #4562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d851b2
fix: resolve tab navigation issue in Firefox with column and note rea…
Aejkatappaja Oct 17, 2024
16833f8
Merge branch 'main' into fj/tab-navigation-firefox
Aejkatappaja Oct 24, 2024
68878a8
Merge branch 'main' into fj/tab-navigation-firefox
Aejkatappaja Oct 26, 2024
4b2e191
Merge branch 'main' into fj/tab-navigation-firefox
Aejkatappaja Oct 29, 2024
6744866
Merge branch 'main' into fj/tab-navigation-firefox
brandstetterm Oct 30, 2024
b4c4cac
refactor(MiniMenu): turn ReactFocusLock autofocus to true
Aejkatappaja Nov 2, 2024
4736a06
refactor(colorpicker): apply autofocus
Aejkatappaja Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ColorPicker/ColorPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const ColorPicker = (props: ColorPickerProps) => {
}

return (
<ReactFocusLock autoFocus={false} className="fix-focus-lock-placement">
<ReactFocusLock autoFocus className="fix-focus-lock-placement">
<ul className="color-picker">
<li className={`${getColorClassName(props.activeColor)} color-picker__item`}>
<button
Expand Down
2 changes: 1 addition & 1 deletion src/components/MiniMenu/MiniMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type MiniMenuProps = {
};

export const MiniMenu = ({className, items}: MiniMenuProps) => (
<ReactFocusLock autoFocus={false}>
<ReactFocusLock autoFocus>
<div className={classNames(className, "mini-menu")}>
{items.map((item) => {
const anchor = uniqueId(`mini-menu-${item.label}`);
Expand Down
Loading