Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a custom hook to handle tooltip display on headings #4557

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

Aejkatappaja
Copy link
Contributor

Description

  • Solving #4553
  • Created a custom hook useTextOverflow to detect whether the text within a referenced container is truncated.
  • Using this hook in Column.tsx to handle the display of the Tooltip component.

Changelog

  • Added useTextOverflow Hook

    • Detects if text is truncated to manage tooltips accordingly.
  • Updated Column Component

    • Integrated useTextOverflow for column name truncation detection.
    • Displays a tooltip when the column name is truncated.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Before:

CleanShot 2024-10-16 at 8  46 25

After:

CleanShot 2024-10-16 at 8  47 09

Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks pretty good so far, just a small nitpick to add :)

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Oct 21, 2024
@Aejkatappaja
Copy link
Contributor Author

Changes applied 5e47cc8

@Schwehn42 Schwehn42 removed the Changes Requested Changes requested by the reviewer label Oct 21, 2024
Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution @Aejkatappaja 🎉

@Schwehn42 Schwehn42 added this pull request to the merge queue Oct 21, 2024
Merged via the queue into inovex:main with commit 1020834 Oct 21, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants