Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: column header overlay #4556

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: column header overlay #4556

merged 1 commit into from
Oct 21, 2024

Conversation

Schwehn42
Copy link
Member

Description

Right now, the color picker isn't correctly rendered in Chrome.
Reason for this is a wrong z-index for column header, which would lead to these problems.
The z-index was introduced in #4391, fixing another issue concerning the emoji overlay.
However, the value itself was less than the notes z-index.

The proposed changes here adjust the z-index of column headers to always be greater than the notes z-index, so all components are explicitly overlayed.

Resolves #4538.

Changelog

  • Added new z-index var $column-header-z-index which is greater than $note-z-index
  • Applied $column-header-z-index to column header
  • Change z-indices in components related to the color picker; if not required removed entirely

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@Schwehn42 Schwehn42 added Bug This pull request or issue contains/fixes a bug Review Needed This pull request is ready for review labels Oct 16, 2024
@Schwehn42 Schwehn42 self-assigned this Oct 16, 2024
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4556.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-6b0e2e8

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-6b0e2e8

Copy link

octomind-dev bot commented Oct 16, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 6b0e2e8

Copy link
Contributor

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏽

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Oct 21, 2024
@Schwehn42 Schwehn42 added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit a5a8699 Oct 21, 2024
12 checks passed
@Schwehn42 Schwehn42 deleted the js/fix-color-picker-overlay branch October 21, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This pull request or issue contains/fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chrome] Colour Picker is hidden behind the Notes
2 participants