-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: marker for edited notes #4277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good all in all! 👍 I do have to backtrack about my opinion that having the edited class below doesn't matter though; having it inline would really look better since it doesn't impact the height. Only problem is that I have no idea how to achieve that 😅
just my two cents, but I strongly believe this current solution to be better:
What do you think @Schwehn42? |
I talked with Selina about that. She said that it's okay this way. But if we find a solution I am happy to change it so that it is inline |
@Resaki1 @mateo-ivc good points, let's do it that way then 👍 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogNoteContent.scss
Outdated
Show resolved
Hide resolved
src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogNoteContent.scss
Outdated
Show resolved
Hide resolved
src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogNoteContent.scss
Outdated
Show resolved
Hide resolved
src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogNoteContent.tsx
Outdated
Show resolved
Hide resolved
…r.io into mi/marker-for-edited-notes
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lookin' good 🙌
The deployment to the dev cluster was successful. You can find the deployment here: https://4277.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 13/14 successful.
commit sha: da0ad90 |
Description
Adding a marker that indicates if a note has been edited or not
Changelog
dto/notes.go
database/migrations
database/notes.go
components/Note
Checklist
(Optional) Visual Changes