Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: marker for edited notes #4277

Merged
merged 19 commits into from
Jul 9, 2024
Merged

feat: marker for edited notes #4277

merged 19 commits into from
Jul 9, 2024

Conversation

mateo-ivc
Copy link
Contributor

Description

Adding a marker that indicates if a note has been edited or not

Changelog

dto/notes.go

  • added field if a note has been edited

database/migrations

  • added field to notes table, that stores if a note has been edited

database/notes.go

  • updates the edited field in the database to true, since text has been changed

components/Note

  • added marker beneath text
  • added css where needed

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

image

image

Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good all in all! 👍 I do have to backtrack about my opinion that having the edited class below doesn't matter though; having it inline would really look better since it doesn't impact the height. Only problem is that I have no idea how to achieve that 😅

src/components/Note/Note.scss Outdated Show resolved Hide resolved
src/components/Note/Note.scss Outdated Show resolved Hide resolved
src/utils/test/getTestApplicationState.ts Outdated Show resolved Hide resolved
src/components/Note/Note.tsx Outdated Show resolved Hide resolved
@Schwehn42 Schwehn42 changed the title Mi/marker for edited notes feat: marker for edited notes Jul 1, 2024
@Resaki1
Copy link
Collaborator

Resaki1 commented Jul 2, 2024

looking good all in all! 👍 I do have to backtrack about my opinion that having the edited class below doesn't matter though; having it inline would really look better since it doesn't impact the height. Only problem is that I have no idea how to achieve that 😅

just my two cents, but I strongly believe this current solution to be better:

  1. This way it is directly visible that the (edited) is not part of the note's text.
  2. This is how other platforms solve it. Jakob's Law (hehe) states that users prefer our site to work like all other sites, and if you look at Whatsapp, Twitter etc., they solve it just like @mateo-ivc has solved it here.
  3. I personally think increasing the height of the note slightly is less bad then cutting the text off earlier than necessary.

What do you think @Schwehn42?

@mateo-ivc
Copy link
Contributor Author

do have to backtrack about my opinion that having the edited class below doesn't matter though; having it inline would really look better since it doesn't impact the height.

I talked with Selina about that. She said that it's okay this way. But if we find a solution I am happy to change it so that it is inline

@Schwehn42
Copy link
Member

@Resaki1 @mateo-ivc good points, let's do it that way then 👍

Schwehn42
Schwehn42 previously approved these changes Jul 2, 2024
@Schwehn42 Schwehn42 dismissed their stale review July 2, 2024 09:23

waiting for #4180 first

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin' good 🙌

Copy link

github-actions bot commented Jul 9, 2024

The deployment to the dev cluster was successful. You can find the deployment here: https://4277.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-da0ad90

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-da0ad90

Copy link

octomind-dev bot commented Jul 9, 2024

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: da0ad90

@mateo-ivc mateo-ivc added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit e6e73d2 Jul 9, 2024
10 checks passed
@mateo-ivc mateo-ivc deleted the mi/marker-for-edited-notes branch July 9, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants