-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: saveable share qr code #4191
Conversation
@brandstetterm seems like
I opted for using 1.,but am open for the other option as well. EDIT (2024-07-17):Using the new theme state hook introduced in #4310, the current theme is now detected and applied to the QR Code. |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/components/SettingsDialog/ShareSession/ShareSession.scss
🐙 OctomindTest Report: 14/14 successful.
commit sha: c692f8b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The deployment to the dev cluster was successful. You can find the deployment here: https://4191.development.scrumlr.fra.ics.inovex.io Deployed Images
|
Co-authored-by: Manuel Brandstetter <[email protected]>
Description
Makes the QR code available in the share view saveable as a file. Note this works for FF and Chrome, but not Safari for me, seems to be a limitation on their part so I won't be bothered 🫣
Closes #4170
Changelog
ShareSession
svg
tocanvas
(makes it saveable)Checklist
(Optional) Visual Changes