Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change github login method from google to github #4187

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

mateo-ivc
Copy link
Contributor

Description

The login method for github users used the google login method. -> Changed this to use the github login method

Changelog

services/users/user.go
changed called method to CreateGitHubUser

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Copy link

github-actions bot commented Jun 3, 2024

The deployment to the dev cluster was successful. You can find the deployment here: https://4187.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-d2afdcd

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-d2afdcd

Copy link

octomind-dev bot commented Jun 3, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: d2afdcd

@mateo-ivc mateo-ivc self-assigned this Jun 3, 2024
@mateo-ivc mateo-ivc added the Review Needed This pull request is ready for review label Jun 3, 2024
Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work™️ 😁

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Jun 3, 2024
@mateo-ivc mateo-ivc added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit fbabb67 Jun 3, 2024
5 of 6 checks passed
@mateo-ivc mateo-ivc deleted the mi/fix-github-login branch June 3, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants