Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allowEditing -> isLocked #4145

Merged
merged 13 commits into from
May 29, 2024
Merged

refactor: allowEditing -> isLocked #4145

merged 13 commits into from
May 29, 2024

Conversation

Schwehn42
Copy link
Member

Description

This would refactor both front -and backend so that AllowEditing is renamed to IsLocked.

Reason: The usage before was to invert AllowEditing in the frontend to isLocked, since it is only used as such. So I thought why not rename the whole thing? See #3955 (comment).

Changelog

Backend

  • dto/boards
    • refactor AllowEditing to IsLocked
  • database/boards
    • refactor AllowEditing to IsLocked
  • change to new name everywhere else
  • add migration to alter column allow_editing to is_locked

Frontend

  • types/board
    • refactor allowEditing to isLocked
  • refactor everywhere else this is used
  • remove boolean inversion when using appSelector
  • change localization

Checklist

  • I have performed a self-review of my own code

(Optional) Visual Changes

@Schwehn42 Schwehn42 mentioned this pull request May 13, 2024
Merged
@Schwehn42 Schwehn42 marked this pull request as ready for review May 14, 2024 08:36
@Schwehn42 Schwehn42 self-assigned this May 21, 2024
@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label May 21, 2024
mateo-ivc
mateo-ivc approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏽

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label May 29, 2024
@Schwehn42 Schwehn42 merged commit f45bf17 into mb/lock-board May 29, 2024
1 check passed
@Schwehn42 Schwehn42 deleted the js/refactor-allow-editing-to-locked-front-and-backend branch May 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandstetterm brandstetterm brandstetterm left review comments

@mateo-ivc mateo-ivc mateo-ivc approved these changes

Assignees

@Schwehn42 Schwehn42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Schwehn42 @brandstetterm @mateo-ivc