Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inline URLs #4123

Merged
merged 12 commits into from
May 6, 2024
Merged

feat: inline URLs #4123

merged 12 commits into from
May 6, 2024

Conversation

Schwehn42
Copy link
Member

Description

This PR adds inline URLs, something I wanted to do for a while now (see #3986).

  • opening in new tab
  • https protocol automatically added if omitted
  • truncating of URL if overflowing
  • colored in accent color

Changelog

  • add Linkify to package.json
  • add new component NoteTextContent
    • render URLs using Linkify
    • add tests
  • use new component in Note component

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Bildschirmfoto 2024-05-03 um 15 38 11

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label May 3, 2024
@Schwehn42 Schwehn42 self-assigned this May 3, 2024
Copy link

octomind-dev bot commented May 3, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 5f7772f

@Schwehn42 Schwehn42 enabled auto-merge May 6, 2024 09:14
@Schwehn42 Schwehn42 added this pull request to the merge queue May 6, 2024
Copy link

github-actions bot commented May 6, 2024

The deployment to the dev cluster was successful. You can find the deployment here: https://4123.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-f10fe10

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-f10fe10

Copy link

octomind-dev bot commented May 6, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: f10fe10

Merged via the queue into main with commit a42a731 May 6, 2024
6 checks passed
@Schwehn42 Schwehn42 deleted the js/note-content-urls branch May 6, 2024 09:24
@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label May 6, 2024
BenedictHomuth pushed a commit that referenced this pull request May 16, 2024
Lennart01 pushed a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants