Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: board reaction spam leading to misplacement #4103

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

Schwehn42
Copy link
Member

Description

Spamming many board reactions would lead to them being displayed below the board, creating a scrollbar.
This has been fixed. Closes #4082.

Changelog

  • BoardReactionMenu: Change container position to from absolute to fixed

How to test this:

I used the following code to test this locally:

useEffect(() => {
    setInterval(() => dispatch(Actions.addBoardReaction("heart")), 25);
  }, []);

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Apr 27, 2024
@Schwehn42 Schwehn42 self-assigned this Apr 27, 2024
Copy link

octomind-dev bot commented Apr 27, 2024

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: d458a8a

@Schwehn42 Schwehn42 enabled auto-merge April 29, 2024 07:37
@Schwehn42 Schwehn42 added this pull request to the merge queue Apr 29, 2024
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4103.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-719113c

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-719113c

Copy link

octomind-dev bot commented Apr 29, 2024

🐙 Octomind

Test Report: 11/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Failed ❌ click

commit sha: 719113c

Merged via the queue into main with commit e29b642 Apr 29, 2024
5 checks passed
@Schwehn42 Schwehn42 deleted the js/board-reaction-spam branch April 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spamming board emojis sometimes flashes a scrollbar
2 participants